Update triage state with latest issue reviews and actions#36
Open
BodenMcHale wants to merge 1 commit into
Open
Update triage state with latest issue reviews and actions#36BodenMcHale wants to merge 1 commit into
BodenMcHale wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This update reflects the latest triage automation run, capturing new issue actions and skipped items based on recent substantive reviews.
Key Changes
recommendationsalways populated — spurious "Fix:" output when status isgood#22 - Identified test gap and CLI output bug in recommendations array handling at src/rules.ts:141, with proposed one-line ternary fixunsafe-none/cross-originget full credit #8, [REVIEW] Permissions-Policy tests: 4 assertions broken by merge regression — main branch CI is red #15, [REVIEW] CSP: wildcard (*) detection covers only default-src and script-src — connect-src *, form-action *, and mid-policy wildcards silently pass #16, [REVIEW] HSTS: max-age=0 (HSTS revocation) scores status 'good' due to bonus points from includeSubDomains and preload #17, [REVIEW] Referrer-Policy:no-referrer-when-downgradeclassified as "strong" — awards full score for the historical browser default that leaks full URLs cross-origin #18, [REVIEW] CSP: missingform-actiondirective not flagged —default-src 'self'leaves form submissions unrestricted #19, [REVIEW] CSP: Content-Security-Policy-Report-Only is invisible to the analyzer — report-only deployments score 0/30 as if no CSP exists #20, [REVIEW] CSP:'unsafe-inline'penalized even when'strict-dynamic'+ nonce is present — false positive flags a recommended strict CSP pattern #21, [REVIEW] X-Frame-Options:checkXFrameOptionsawards 15/15 "good" for anyframe-ancestorsvalue — includingframe-ancestors *which provides zero clickjacking protection #23) that received recent substantive triage reviews from BodenMcHale, all within the 48-hour skip windowNotable Details
The skipped issues cover a range of CSP analyzer improvements including:
unsafe-none/cross-originget full credit #8, [REVIEW] X-Frame-Options:checkXFrameOptionsawards 15/15 "good" for anyframe-ancestorsvalue — includingframe-ancestors *which provides zero clickjacking protection #23)form-actiondirective not flagged —default-src 'self'leaves form submissions unrestricted #19)'unsafe-inline'penalized even when'strict-dynamic'+ nonce is present — false positive flags a recommended strict CSP pattern #21)All skipped items have documented timestamps and specific code locations referenced in their review comments.
https://claude.ai/code/session_015heuhDGVdtq6M7e4q8vgPj