Skip to content

Fix for docker github workflow#251

Draft
ewainberg wants to merge 7 commits into
devfrom
issue/184-fix-docker-workflow
Draft

Fix for docker github workflow#251
ewainberg wants to merge 7 commits into
devfrom
issue/184-fix-docker-workflow

Conversation

@ewainberg
Copy link
Copy Markdown
Collaborator

@ewainberg ewainberg commented Feb 19, 2025

Adds a check for the docker container inside github workflow

Comment thread app/routes/dev_auth.py
Comment on lines +54 to +61
rr.set_cookie(
key="token",
value=bearer,
httponly=True,
samesite="lax",
secure=False,
max_age=max_age,
)

Check warning

Code scanning / CodeQL

Failure to use secure cookies

Cookie is added without the Secure attribute properly set.
@ewainberg ewainberg force-pushed the issue/184-fix-docker-workflow branch 2 times, most recently from 3792b7b to 9e60cb9 Compare February 19, 2025 02:23
@ewainberg ewainberg force-pushed the issue/184-fix-docker-workflow branch from 9e60cb9 to 3892f38 Compare February 19, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants