feature(76471): enforce Java version consistency check & running unit tests inside Docker #20
Merged
bogdandina merged 1 commit intomainfrom Apr 16, 2026
Conversation
haphut
reviewed
Mar 31, 2026
haphut
reviewed
Mar 31, 2026
haphut
reviewed
Mar 31, 2026
haphut
reviewed
Mar 31, 2026
Contributor
haphut
left a comment
haphut
left a comment
There was a problem hiding this comment.
Great work! I like the general approach and left a few comments.
Contributor
Author
I updated the PR. Please have one more review on it. Thanks! |
bogdandina
changed the title
haphut
reviewed
Apr 2, 2026
haphut
reviewed
Apr 2, 2026
Contributor
|
Looking good! |
haphut
reviewed
Apr 2, 2026
Contributor
haphut
left a comment
haphut
left a comment
There was a problem hiding this comment.
LGTM. A few more nits as comments.
Contributor
|
Also, please rebase onto |
…code them feat(76471): check Java version alignment between Dockerfile and pom.xml feat(76471): check Java version alignment between Dockerfile and pom.xml feat(76471): check Java version alignment between Dockerfile and pom.xml feat(76471): fix the .gitignore and remove the scripts/__pycache__ fix(76471): fix shared workflow scripts checkout using hardcoded repo and workflow_sha github.workflow_ref inside a reusable workflow returns the caller's workflow ref instead of the shared workflow's ref, causing the scripts checkout to target the wrong repository. Replace dynamic resolution with a hardcoded repository name and github.workflow_sha which correctly references the reusable workflow's commit SHA. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> feat(76471): potential fix test(76471): add unit tests for validate_java_version_consistency.py and CI workflow feat(76455): inline the test layer of the Dockerfile in the CI/CD for simplifying the microservice's Dockerfiles feat(76471): fixes after PR review feat(76471): fixes++
bogdandina
force-pushed
the
feature/76471_enforce-java-version-consistency-check
branch
from
885a6fa to
ea5150b
Compare
bogdandina
deleted the
feature/76471_enforce-java-version-consistency-check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.