test: verify KILL cancels INSERT SELECT#8151
Merged
Merged
Conversation
Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces unit tests to verify that 'KILL QUERY' and 'KILL [process_id]' commands successfully cancel 'INSERT INTO ... SELECT ...' operations. To support these tests, mock components such as 'PendingRecordBatchStream' and 'PendingDataSource' were implemented, and test setup helpers were refactored. Reviewer feedback recommends replacing several instances of '.unwrap()' with proper error propagation and context using 'snafu' to align with the project's error handling standards.
Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
Closes #6334
What's changed and what's your intention?
This PR adds tests to verify that tracked
INSERT INTO ... SELECTstatements can be cancelled through the process manager.The tests cover both supported kill forms:
KILL QUERY <connection_id>KILL '<frontend>/<process_id>'The test uses a pending source table scan to keep
INSERT INTO target SELECT * FROM sourcerunning, then verifies thatKILLmakes the original insert task returnCancelledinstead of only disappearing fromSHOW PROCESSLIST.This does not change runtime logic. It only strengthens coverage for the existing insert-select process tracking and cancellation path.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.