Render Fill and Stroke via List<Graphic> by YohYamasaki · Pull Request #4111 · GraphiteEditor/Graphite

YohYamasaki · 2026-05-06T08:31:33Z

Partly closes #2779

This PR adds foundation of the renderer to handle List<Graphic> as a paint source of fill and stroke.

Demo

render-fill-and-stroke-via-list-graphic.mp4

The demo file can be found in below.
render-fill-and-stroke-via-list-graphic.graphite.zip

Notes

Added converter from Fill / Color to List<Graphic> to avoid breaking current node flow related to the Fill and Stroke node. This should be removed after the future refactoring of the node.
Added ATTR_FILL_GRAPHIC and ATTR_STROKE_PAINT_GRAPHIC attribute keys for storing the paints List<Graphic> on a List<Vector> item.
Refactor vello / SVG renderer to use List<Graphic> as a fill and stroke paint source.
Added fill_graphic and stroke_paint_graphic debug nodes that stores any Graphic castable List into the corresponding attributes to test the clipping paint pass, as it is not available in any production nodes.
RenderExt implementations for PathStyle, Fill are no longer needed, now we have implementation for List<Graphic> instead. The same for Stroke is now shrunk to only generate the shape related attributes.
For the sake of simplifying the same implementation for stroke and also tiling, clipping paint for SVG is implemented using the <pattern> element instead of the <clipPath>.

gemini-code-assist

Code Review

This pull request introduces functionality to convert Fill styles into graphical tables, including a new to_transform method for the Gradient struct and associated unit tests. Feedback suggests refactoring the private fill_to_paint function into an implementation of the IntoGraphicTable trait for Fill to align with existing architectural patterns and optimize performance by avoiding unnecessary clones.

YohYamasaki · 2026-05-15T04:05:12Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors the vector fill system to use a List representation, enabling complex fills such as vectors and rasters via clipping. It updates the SVG and Vello renderers to support the ATTR_FILL_GRAPHIC attribute and introduces a fill_graphic debug node. Review feedback identifies high-severity performance bottlenecks caused by frequent cloning of the graphic list in both render loops. Additionally, there is a discrepancy where the SVG renderer only processes the first fill element compared to Vello's multi-fill support, and a concern regarding SVG bloat from redundant clip path generation in complex meshes.

cubic-dev-ai

No issues found across 6 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

# Conflicts: # node-graph/libraries/rendering/src/renderer.rs

This simplifies the future implementation of clipping-based rendering for strokes, as the stroke does not support the use of a clip path but rather paint sources from a paint server.

cubic-dev-ai

1 issue found across 6 files

Confidence score: 3/5

There is a concrete user-facing rendering risk: in node-graph/libraries/rendering/src/render_ext.rs, an empty List<Color> produces an empty string rather than fill="none", so SVG elements can render black instead of transparent.
Given the high confidence (9/10) and meaningful severity (7/10), this is more than a minor edge case and could cause visible regressions in generated SVG output.
Pay close attention to node-graph/libraries/rendering/src/render_ext.rs - ensure empty color lists map to explicit transparent fill behavior (fill="none").

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

This exposes List's attributes to message handlers, enabling them to access the necessary attribute data such as ATTR_STROKE_PAINT_GRAPHIC as `Fill` and `Stroke` will not have paint information in the future.

Also extracts `fill_graphic_list_at` / `stroke_paint_graphic_list_at` to share the row-attribute lookup across the existing call sites.

This reverts commit 4285243

Add `fill_attributes` / `stroke_paint_attributes` to `DocumentMetadata` so the `ExpandFillStrokeOnSelectedLayers` handler can read row paint visibility without exposing entire `List<Vector>`.

cubic-dev-ai

4 issues found across 13 files

Confidence score: 3/5

There is concrete rendering-behavior risk in node-graph/libraries/graphic-types/src/graphic.rs: Graphic::is_opaque/is_fully_transparent reportedly ignore ATTR_OPACITY and ATTR_OPACITY_FILL, which can misclassify partially transparent graphics as opaque.
node-graph/libraries/graphic-types/src/graphic.rs also appears to evaluate only the first paint entry in List<Graphic>, so multi-layer fill/stroke paint setups may produce incorrect opacity/transparent decisions.
This looks mergeable with caution, but the combined medium-to-high severity issues suggest user-visible rendering mismatches are plausible (including the gradient-bounds mismatch noted in node-graph/libraries/rendering/src/renderer.rs).
Pay close attention to node-graph/libraries/graphic-types/src/graphic.rs and node-graph/libraries/rendering/src/renderer.rs - opacity classification and stroke gradient bounds may diverge from expected/SVG behavior.

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

gemini-code-assist Bot reviewed May 6, 2026

View reviewed changes

Comment thread node-graph/libraries/graphic-types/src/graphic.rs Outdated

YohYamasaki force-pushed the render-fill-via-graphic branch 3 times, most recently from 1e575b6 to 28b9fba Compare May 12, 2026 14:11

YohYamasaki force-pushed the render-fill-via-graphic branch from dd79824 to 212e088 Compare May 15, 2026 02:04

YohYamasaki changed the title ~~Render Fill via Graphic~~ Render Fill via List<Graphic> May 15, 2026

gemini-code-assist Bot reviewed May 15, 2026

View reviewed changes

Comment thread node-graph/libraries/rendering/src/renderer.rs Outdated

Comment thread node-graph/libraries/rendering/src/renderer.rs Outdated

Comment thread node-graph/libraries/rendering/src/renderer.rs Outdated

Comment thread node-graph/libraries/rendering/src/renderer.rs Outdated

YohYamasaki marked this pull request as ready for review May 15, 2026 05:22

cubic-dev-ai Bot reviewed May 15, 2026

View reviewed changes

YohYamasaki force-pushed the render-fill-via-graphic branch from e045d30 to 12d6335 Compare May 15, 2026 06:30

Keavon force-pushed the master branch 2 times, most recently from 4b7a823 to 847b8e9 Compare May 17, 2026 14:37

timon-schelling force-pushed the master branch 2 times, most recently from 15fcaac to d5f0140 Compare May 17, 2026 15:37

YohYamasaki added 8 commits May 18, 2026 09:03

Add conversion from Fill to Table<Graphic>

e192269

Refactor Vector vello renderer for Gradient / Color

25358d3

# Conflicts: # node-graph/libraries/rendering/src/renderer.rs

Refactor Vector SVG renderer for Gradient / Color

8a2aec6

Fix conflicts

bad70f7

Add basic clipping-based fill for SVG rendering

7ee4117

Use Cow to avoid cloning graphic list for fill

2859235

Cleanup for Cow usage

42991b4

format code

a03afed

YohYamasaki marked this pull request as draft May 18, 2026 00:58

YohYamasaki force-pushed the render-fill-via-graphic branch from 335430e to 9df8439 Compare May 18, 2026 09:12

Use <pattern> instead of <clipPath> for clip

ac3f317

This simplifies the future implementation of clipping-based rendering for strokes, as the stroke does not support the use of a clip path but rather paint sources from a paint server.

YohYamasaki force-pushed the render-fill-via-graphic branch from 9df8439 to ac3f317 Compare May 19, 2026 00:52

YohYamasaki added 2 commits May 19, 2026 10:56

Move svg pattern rendering function to RenderExt

189557e

Fix comment

1802829

YohYamasaki marked this pull request as ready for review May 19, 2026 01:57

cubic-dev-ai Bot reviewed May 19, 2026

View reviewed changes

Comment thread node-graph/libraries/rendering/src/render_ext.rs Outdated

YohYamasaki and others added 5 commits May 19, 2026 04:25

Fix empty fill list rendering as default black

3091a6f

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

Move opaque check function to Graphic impl

3fd6116

Add color converter and debug node to use graphic

746d783

WIP: Use List<Graphic> to render Color & Gradient

1adeb4c

Use Arc<List<Vector>> for vector_data metadata

4285243

This exposes List's attributes to message handlers, enabling them to access the necessary attribute data such as ATTR_STROKE_PAINT_GRAPHIC as `Fill` and `Stroke` will not have paint information in the future.

YohYamasaki mentioned this pull request May 20, 2026

Render stroke via List<Graphic> #4160

Closed

YohYamasaki marked this pull request as draft May 21, 2026 01:04

YohYamasaki changed the title ~~Render Fill via List<Graphic>~~ Render Fill and Stroke via List<Graphic> May 21, 2026

Recurse opacity checks on nested Graphic

44c03a3

Also extracts `fill_graphic_list_at` / `stroke_paint_graphic_list_at` to share the row-attribute lookup across the existing call sites.

YohYamasaki closed this May 21, 2026

YohYamasaki deleted the render-fill-via-graphic branch May 21, 2026 01:22

YohYamasaki restored the render-fill-via-graphic branch May 21, 2026 01:24

YohYamasaki reopened this May 21, 2026

YohYamasaki added 6 commits May 21, 2026 12:05

Fix fill and stroke visibility check degradation

18362b1

Fix clipping based stroke paint positioning

1b44cb2

Refactor vello renderer for stroke to use graphic

8e59653

Reduce Fill / Stroke.color to List<Graphic> allocations

7603828

Revert "Use Arc<List<Vector>> for vector_data metadata"

721daa3

This reverts commit 4285243

Expose paint row attributes as dedicated metadata for vectors

671da90

Add `fill_attributes` / `stroke_paint_attributes` to `DocumentMetadata` so the `ExpandFillStrokeOnSelectedLayers` handler can read row paint visibility without exposing entire `List<Vector>`.

YohYamasaki marked this pull request as ready for review May 22, 2026 08:58

cubic-dev-ai Bot reviewed May 22, 2026

View reviewed changes

Comment thread node-graph/libraries/graphic-types/src/graphic.rs

Comment thread node-graph/nodes/math/src/lib.rs

Comment thread node-graph/libraries/graphic-types/src/graphic.rs

Comment thread node-graph/libraries/rendering/src/renderer.rs

YohYamasaki added 2 commits May 22, 2026 18:26

Fix transparency check to consider fill opacity

11724a5

Fix consistency of gradient placement for SVG stroke

770a90e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Render Fill and Stroke via List<Graphic>#4111

Render Fill and Stroke via List<Graphic>#4111
YohYamasaki wants to merge 25 commits into
GraphiteEditor:masterfrom
YohYamasaki:render-fill-via-graphic

YohYamasaki commented May 6, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

YohYamasaki commented May 15, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

YohYamasaki commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Demo

Notes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

YohYamasaki commented May 15, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

YohYamasaki commented May 6, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading