Repository navigation
0.9.29: TypeScript leaks absolute-path slug ids into links source endpoints (C# fixed by #2250, TS not) #2262
Description
Activity
Any read on this? Happy to test a patch or provide a fuller repro if that helps.
Fixed in v0.9.30. The symbol-resolution pass now parses .tsx with the TSX grammar (it was using the plain TS grammar, so JSX misparsed and floated nested handlers to top level, emitting calls edges from an absolute-stem source with no node). A calls edge is also never emitted from an unowned source, and a general backstop canonicalizes any node-less absolute-derived endpoint. No node id or edge endpoint carries the scan-root slug now. https://github.com/Graphify-Labs/graphify/releases/tag/v0.9.30
Thanks, v0.9.30 does fix the case I filed: the
.tsx-parsed-as-.tshandler misparse is gone, no more slug-sourcecallsedges. Verified on the same TS project (74,271 nodes), zero of those remain.There's a residual of the same class the backstop was meant to cover, on a different edge type.
imports/imports_from/references/re_exportsedges still emit an absolute-path-derived slug as the target when the target resolves to no node. Counts on that project:imports: 4,089imports_from: 2,505references: 67re_exports: 16
The bulk (~5,160) are imports to generated files that aren't in the checkout (e.g.
src/**/graphql/generated/graphql.ts, a codegen output that's gitignored). graphify can't node a file that isn't on disk, so the endpoint comes out as the absolute-scan-path slug (<abs-scan-path>_..._graphql), which is machine-specific and differs per checkout path, the same reproducibility problem as the original report. The rest (~70) are references to markdown/docs.So the general backstop that canonicalizes node-less absolute-derived endpoints doesn't reach the
imports/imports_from/references/re_exportspath. Same fix idea: for a target that resolves to no node, either canonicalize it the way the backstop does elsewhere, or drop the edge, rather than leaving the absolute-derived slug.Happy to share a fuller extract if useful.
Follow-up to #2243. Thanks for the 0.9.29 fix (#2250), it cleaned up the C# case. TypeScript still leaks, in a slightly different spot.
What happens
In a TypeScript graph, a large number of
linksentries have asourcethat is an absolute-scan-path-derived slug rather than a real node id. The slug is the scan path lowercased with every run of non-alphanumerics collapsed to_, followed by the file's repo-relative path and the function name, for exampleabs_scan_path_slug_packages_account_src_components_paymentmethods_prepaybalancecontainer_invoicebalancesubsection. Thetargetof the same edge is a clean scope-relative id (packages_account_src_settings_basesettingssection_constructrowwithid).Two things about the leaked source:
nodesentirely, so this is not only the id-relativization gap from 0.9.28: machine-slug node-ids still leak into links endpoints (residual of #1899, now in edges not nodes) #2243. The extractor is emitting acallsedge for a caller it never materialized as a node, and identifying that caller by absolute path.callsedges (the caller), not the target.C# vs TypeScript in the same version
Same repo, same graphify 0.9.29, two scopes:
So the 0.9.29 relativization landed for the C# extractor but not the TypeScript one.
Why it matters
The slug is derived from the absolute scan path, so the same source tree built on two machines (or two checkout paths) produces different
graph.jsonfiles. We commit graphs to git, so every rebuild on a different path shows a spurious diff, and the underlying non-determinism is general. Same reproducibility and cross-machine caching problem as #2243.Repro
It shows up in a TypeScript monorepo (a
packages/*layout with cross-package imports). A minimal two-file TS project does not trigger it, and neither does a class with arrow-property handlers calling across two files, so it correlates with the larger structure rather than a single syntactic form. The leaked callers are handler-style functions (invoicebalancesubsection,handletabclick,handleapply) whose containing symbol does not appear innodes. Happy to share a fuller extract from the affected graph if useful.Suggested fix
Apply the same relativization as #2243/#1899 to the TypeScript extractor's edge-source identifiers, and/or materialize the caller node so the edge references a real scope-relative id instead of an absolute path.