Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Co-authored-by: thalescb <8635591+thalescb@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unused ProfileTextAreaField import in governance-widget
Remove unused governance profile import blocking lint
Oct 26, 2026
Collaborator
|
@copilot On this same branch, also fix the remaining root lint failure in apps/ai-credits-web/src/App.tsx. depositBonusPercent and streamBonusPercent (line 327) have been unused since the bonus text was removed from the landing page in #208/#210, and 32e0270 removed their last use. Remove the useDiscountConfig call in LandingPage, the useDiscountConfig function, and the imports that become unused: createBackendClient, DEFAULT_DISCOUNT_CONFIG, DiscountConfig, useEffect and useState. No other changes, no new PR. Then run the root lint, paste its full output, and list the files you changed. |
Co-authored-by: thalescb <8635591+thalescb@users.noreply.github.com>
Contributor
Author
Addressed in e8a5f44 on this branch. Removed the LandingPage call, Changed file in this follow-up:
Targeted lint and root Full root lint output |
thalescb
changed the title
thalescb
marked this pull request as ready for review
October 26, 2026 13:51
Collaborator
|
CI failure here is the Citizen Claim live-RPC test (states.spec.ts:88), unrelated to this diff. It fails on main too and is tracked in #268, with the fix in progress in #269. Same commit passed on a rerun: https://github.com/GoodDollar/GoodWidget/actions/runs/40331593126 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root lint fails on main (#270). Two spots:
governance-widget ProfileStepContent.tsx imported ProfileTextAreaField and never used it. Removed.
ai-credits-web App.tsx fetched the discount config on the landing page and never used it (the bonus text was removed in #208/#210, its last use in 32e0270). Removed the fetch, the useDiscountConfig hook and the imports it left unused. No visible change on the page.
Root lint passes: 28/28 tasks, 0 errors (remaining warnings are pre-existing).
Fixes #270