Repository navigation
refactor(streaming-widget): drop subgraph workaround for streaming-sdk 1.1.0 - #229
Merged
Merged
Conversation
blueogin
requested review from
a team and
sirpy
and
a lite review from Copilot
September 2, 2026 15:57
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The refactor is self-contained and consistent, with only a minor documentation wording tweak noted in review comments.
Pull request overview
This PR updates the streaming widget to rely on @goodsdks/streaming-sdk v1.1.0’s new status filtering for queryStreams, allowing ended streams to be fetched via the SDK and removing the now-unnecessary custom subgraph workaround module.
Changes:
- Bump
@goodsdks/streaming-sdkfrom1.0.0to1.1.0. - Replace the hand-rolled
streamsSubgraphGraphQL querying withSubgraphClient.queryStreams({ status: 'all' }). - Remove
packages/streaming-widget/src/adapter/streamsSubgraph.tsand update adapter/domain types accordingly.
File summaries
| File | Description |
|---|---|
| pnpm-lock.yaml | Locks the workspace dependency graph to @goodsdks/streaming-sdk@1.1.0. |
| packages/streaming-widget/package.json | Bumps @goodsdks/streaming-sdk to 1.1.0. |
| packages/streaming-widget/src/adapter/useStreamingClients.ts | Instantiates/passes a SubgraphClient instead of a raw subgraph URL. |
| packages/streaming-widget/src/adapter/useStreamingData.ts | Uses subgraphClient.queryStreams({ direction: 'all', status: 'all' }) to populate streams + history. |
| packages/streaming-widget/src/adapter/domain.ts | Switches query-row typing to SDK StreamQueryResult and uses isActive/closedAtTimestamp fields. |
| packages/streaming-widget/src/adapter.ts | Wires subgraphClient through the adapter instead of streamsEndpoint. |
| packages/streaming-widget/src/adapter/streamsSubgraph.ts | Deleted: removes the custom GraphQL/pagination workaround for ended streams. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
- Files reviewed: 6/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
191
to
+192
| /** Superfluid subgraph endpoint for the connected chain */ | ||
| streamsEndpoint: string | null | ||
| subgraphClient: SubgraphClient | null |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@goodsdks/streaming-sdk1.1.0 adds astatusfilter toqueryStreams, socurrentFlowRate_gt: "0"is no longer hardcoded into the query documents and ended streams can finally be fetched through the SDK.That was the only reason
streamsSubgraph.tsexisted — a hand-rolled GraphQL module issuing the same query without the filter, added so the History tab could show closed streams. It carried a "drop this once upstream grows a way to include ended streams" note. Upstream grew one, so this removes it and puts the widget back onSubgraphClient.About # (link your issue here)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: