Minor clarity fixes in gix-commitgraph#1875
Merged
Sebastian Thiel (Byron) merged 2 commits intoGitoxideLabs:mainfrom Mar 11, 2025
Merged
Minor clarity fixes in gix-commitgraph#1875Sebastian Thiel (Byron) merged 2 commits intoGitoxideLabs:mainfrom
gix-commitgraph#1875Sebastian Thiel (Byron) merged 2 commits intoGitoxideLabs:mainfrom
Conversation
Eliah Kagan (EliahKagan)
force-pushed
the
spell
branch
from
eb06bbd to
87a5043
Compare
The `#:~:text` in the anchor was no longer working, as tested in Chromium-based browsers that ordinarily support such links. Like any broken anchor, it didn't keep the page from resolving. But it didn't jump to (nor participate in any highlighting of) specific text. Fortunately, the relevant text is near the top of the page. So the original intent of the longer and more complicated URL is satisfied in the simpler URL.
Eliah Kagan (EliahKagan)
force-pushed
the
spell
branch
from
87a5043 to
da64358
Compare
Sebastian Thiel (Byron)
approved these changes
Mar 11, 2025
Member
Sebastian Thiel (Byron)
left a comment
Sebastian Thiel (Byron)
left a comment
There was a problem hiding this comment.
Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a misspelled test name, and simplifies a documentation URL that had a long
#:~:textanchor that no longer worked even in browsers that support them and that (fortunately) is not needed for the page to be useful.This is pretty minor, but it doesn't seem to naturally go together with any other PRs I have open or plan to open anytime soon. So it is its own PR.
(As elsewhere, the
test-fixtures-windowsfailure here is unrelated to this PR; see #1849 and #1870. Thetest-32bitfailure is likewise unrelated; see #1874.)