Skip to content

Show if item is unbreaking as part of the lore#6348

Merged
valaphee merged 2 commits into
GeyserMC:masterfrom
valaphee:lore-unbreaking
May 5, 2026
Merged

Show if item is unbreaking as part of the lore#6348
valaphee merged 2 commits into
GeyserMC:masterfrom
valaphee:lore-unbreaking

Conversation

@valaphee
Copy link
Copy Markdown
Member

@valaphee valaphee commented May 4, 2026

Copilot AI review requested due to automatic review settings May 4, 2026 15:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Bedrock-side tooltip/lore entry so Java “Unbreakable” items surface that status to Bedrock players during item translation.

Changes:

  • Appends an “item.unbreakable” lore line when the UNBREAKABLE component is present and not hidden by tooltip display options.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread core/src/main/java/org/geysermc/geyser/translator/item/ItemTranslator.java Outdated
@eclipseisoffline
Copy link
Copy Markdown
Member

A relevant PR is #5692

@valaphee valaphee force-pushed the lore-unbreaking branch from 8b6dac5 to 702df0b Compare May 4, 2026 15:40
Copilot AI review requested due to automatic review settings May 5, 2026 17:40
@valaphee valaphee force-pushed the lore-unbreaking branch from 9f901ac to 8b6dac5 Compare May 5, 2026 17:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@valaphee valaphee force-pushed the lore-unbreaking branch from e33f5ea to 5827aa9 Compare May 5, 2026 17:43
@valaphee valaphee merged commit abdba21 into GeyserMC:master May 5, 2026
2 checks passed
@valaphee valaphee deleted the lore-unbreaking branch May 5, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants