Skip to content

Add biome uniform-section fast-path #6312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onebeastchris merged 1 commit into from
Apr 21, 2026
+36 −19
Merged

Add biome uniform-section fast-path #6312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 36 additions & 19 deletions core/src/main/java/org/geysermc/geyser/translator/level/BiomeTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,31 +63,48 @@ public static BlockStorage toNewBedrockBiome(GeyserSession session, DataPalette
} else {
BlockStorage storage;
if (!(palette instanceof GlobalPalette)) {
// Prevent resizing by allocating what we can ahead of time
BitStorage bitStorage = biomeData.getStorage();
int size = palette.size();
BitArray bitArray = BitArrayVersion.forBitsCeil(bitStorage.getBitsPerEntry())
.createArray(BlockStorage.SIZE);

IntList bedrockPalette = new IntArrayList(size);

for (int i = 0; i < size; i++) {
int javaId = palette.idToState(i);
bedrockPalette.add(biomeTranslations.byId(javaId).intValue());
// Fast-path: if all 64 biome cells use the same palette index,
// use a singleton instead of computing the full 4096-entry BitArray
int firstIdx = bitStorage.get(0);
boolean allSame = true;
for (int i = 1; i < 64; i++) {
if (bitStorage.get(i) != firstIdx) {
allSame = false;
break;
}
}

// Each section of biome corresponding to a chunk section contains 4 * 4 * 4 entries
for (int i = 0; i < 64; i++) {
int idx = bitStorage.get(i);
int x = i & 3;
int y = (i >> 4) & 3;
int z = (i >> 2) & 3;
// Convert biome coordinates into block coordinates
// Bedrock expects a full 4096 blocks
multiplyIdToStorage(bitArray, idx, x, y, z);
}
if (allSame) {
int biomeId = biomeTranslations.byId(palette.idToState(firstIdx)).intValue();
storage = new BlockStorage(SingletonBitArray.INSTANCE, IntLists.singleton(biomeId));
} else {
// Prevent resizing by allocating what we can ahead of time
BitArray bitArray = BitArrayVersion.forBitsCeil(bitStorage.getBitsPerEntry())
.createArray(BlockStorage.SIZE);

IntList bedrockPalette = new IntArrayList(size);

storage = new BlockStorage(bitArray, bedrockPalette);
for (int i = 0; i < size; i++) {
int javaId = palette.idToState(i);
bedrockPalette.add(biomeTranslations.byId(javaId).intValue());
}

// Each section of biome corresponding to a chunk section contains 4 * 4 * 4 entries
for (int i = 0; i < 64; i++) {
int idx = bitStorage.get(i);
int x = i & 3;
int y = (i >> 4) & 3;
int z = (i >> 2) & 3;
// Convert biome coordinates into block coordinates
// Bedrock expects a full 4096 blocks
multiplyIdToStorage(bitArray, idx, x, y, z);
}

storage = new BlockStorage(bitArray, bedrockPalette);
}
} else {
storage = new BlockStorage(0);

Expand Down
Loading