Switch to JSpecify for nullability annotations in API module#6303
Merged
Conversation
… JSpecify Ensure all Nullable annotations are inline per JSpecify standard
eclipseisoffline
added
PR: Feature
onebeastchris
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches to JSpecify for nullability annotations in the API module. All packages in the API now have a
package-info.javafile with a@NullMarkedannotation, which applies to all types in the package. This includes but is not limited to method return values, parameters, fields, generic type parameters, arrays, and more.Because of this change, all
@NonNullannotations have been removed, as they are no longer necessary. All@Nullableannotations have been replaced by JSpecify's, and those on a separate line have been moved to be in-line, as per JSpecify's standard.Some extra
@Nullableannotations have been added where they should be.This PR is currently targetting 26.1, but can be changed to target master if merged in a later version.
Depends on api#12 for JSpecify in the base API.