Skip to content

Add support for redirects on 410 responses #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErvinsA merged 5 commits into from
Oct 7, 2025
Merged

Add support for redirects on 410 responses #155

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f784af
Add support for redirects on 410 responses
Dec 17, 2024
64ce4c1
Change to use int options instead of boolean
wezz Sep 29, 2025
fdd9f73
Remove trace of old configuration
wezz Sep 29, 2025
ad8010c
Update to .net 8
wezz Sep 30, 2025
c1e6a6e
Ensure we always rely on on the configuration and don't hardcode 404
wezz Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ public void ConfigureServices(IServiceCollection services)
o.IgnoredResourceExtensions = new[] { "jpg", "gif", "png", "css", "js", "ico", "swf", "woff" };
o.Logging = LoggerMode.On;
o.LogWithHostname = false;
o.ActiveStatusCodes = new int[] { StatusCodes.Status404NotFound };
o.AddProvider<NullNotFoundHandlerProvider>();
});

Expand Down Expand Up @@ -151,6 +152,8 @@ If the `bufferSize` is set to `0`, the `threshold` value will be ignored, and ev

**LogWithHostname**: Set to `true` to include hostname in the log. Useful in a multisite environment with several hostnames/domains. Default is `false`

**ActiveStatusCodes**: A integerlist with the status codes that NotFoundHandler will be active on. (Ex. ```options.ActiveStatusCodes = new int[] { StatusCodes.Status404NotFound, StatusCodes.Status410Gone };```)

### Specifying ignored resources

**IgnoredResourceExtensions**
Expand Down
4 changes: 2 additions & 2 deletions src/Geta.NotFoundHandler/Core/RequestHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ public virtual void Handle(HttpContext context)
return;
}

if (context.Response.StatusCode != 404)
if (context.Response.StatusCode != StatusCodes.Status404NotFound && (_configuration.ActiveStatusCodes.Any() && !_configuration.ActiveStatusCodes.Contains(context.Response.StatusCode)))
Comment thread
wezz marked this conversation as resolved.
Outdated
{
LogDebug("Not a 404 response.", context);
LogDebug("Not a accepted statuscode.", context);
return;
}

Expand Down
2 changes: 2 additions & 0 deletions src/Geta.NotFoundHandler/Infrastructure/Configuration/NotFoundHandlerOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using Geta.NotFoundHandler.Core;
using Geta.NotFoundHandler.Core.Suggestions;
using Geta.NotFoundHandler.Core.Redirects;
using Microsoft.AspNetCore.Http;

namespace Geta.NotFoundHandler.Infrastructure.Configuration
{
Expand All @@ -20,6 +21,7 @@ public class NotFoundHandlerOptions
public bool UseInternalScheduler { get; set; }
public string InternalSchedulerCronInterval { get; set; } = "0 0 * * *";
public FileNotFoundMode HandlerMode { get; set; } = FileNotFoundMode.On;
public int[] ActiveStatusCodes { get; set; } = new int[] { StatusCodes.Status404NotFound };
public TimeSpan RegexTimeout { get; set; } = TimeSpan.FromMilliseconds(100);

public string[] IgnoredResourceExtensions { get; set; } =
Expand Down
Loading