Add cacheability to metastore response. - #4782
Draft
swirtSJW wants to merge 1 commit into
Draft
Conversation
swirtSJW
commented
Sep 2, 2026
| // Actively declare cacheable. Otherwise Drupal core will add 'no-cache'. | ||
| $response->headers->set( | ||
| 'Cache-Control', | ||
| 'public, max-age=3600, s-maxage=86400' |
Contributor
Author
There was a problem hiding this comment.
The numbers might need some tweaking.
swirtSJW
marked this pull request as draft
September 2, 2026 03:35
Contributor
Author
|
There is limits to what can be tested locally. Willl have to deploy to an acquia environment to truly test it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4783
Describe your changes
These changes are an initial stab at defining caching. Discussion is probably needed about the ideal numbers for caching.
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation