Conversation
6 tasks
Contributor
Author
Member
|
@swirtSJW where are these programatic revisions happening? If in DKAN core, it seems like the revision time should be set at the place in the code where the new revision is being created, not later in a hook? |
Contributor
Author
|
Closing this in favor of #4755 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #4621
Describe your changes
This explicitly sets data node revision time so that programatic changes like publish reflect the time of the publish, and don't repeat the time of the draft.

This results in revisions that look like
as opposed to the current situation of
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation