Skip to content

#4621 Add revision time on presave. - #4753

Closed
swirtSJW wants to merge 2 commits into
4.xfrom
4621-set-revision-date-4
Closed

swirtSJW wants to merge 2 commits into
4.xfrom
4621-set-revision-date-4

Conversation

@swirtSJW

@swirtSJW swirtSJW commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Fixes #4621

Describe your changes

This explicitly sets data node revision time so that programatic changes like publish reflect the time of the publish, and don't repeat the time of the draft.
This results in revisions that look like
different revision dates

as opposed to the current situation of

confusing same revision dates

QA Steps

  • git checkout 4621-set-revision-date-4
  • Save a dataset as draft.
  • publish it using either a drush command or a bulk operation in the UI.
  • Visit the revisions tab for the dataset. validate that the first line for each of the recent revisions has its own date and time. (rather than repeating the time.)
  • validate that the revision message, which also looks like a time stamp did not change should still say something like "Created on " and the date should match the message from the draft revision.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@swirtSJW swirtSJW mentioned this pull request Jul 6, 2026
6 tasks
@swirtSJW

swirtSJW commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Proof of working
image

@swirtSJW
swirtSJW requested a review from dafeder July 7, 2026 14:50
@dafeder

dafeder commented Jul 7, 2026

Copy link
Copy Markdown
Member

@swirtSJW where are these programatic revisions happening? If in DKAN core, it seems like the revision time should be set at the place in the code where the new revision is being created, not later in a hook?

@swirtSJW swirtSJW changed the title 4621 Add revision time on presave. #4621 Add revision time on presave. Jul 8, 2026
@swirtSJW

swirtSJW commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Closing this in favor of #4755

@swirtSJW swirtSJW closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publishing a metastore does not change revision date

2 participants