#4732 - Limit the amount of items for metastore schema API request - #4733
Open
stefan-korn wants to merge 1 commit into
Open
#4732 - Limit the amount of items for metastore schema API request#4733stefan-korn wants to merge 1 commit into
stefan-korn wants to merge 1 commit into
Conversation
dafeder
requested changes
Jun 15, 2026
dafeder
left a comment
Member
There was a problem hiding this comment.
I talked about this on the issue comments but:
- I think if we introduce limit we should also have offset, so that people can paginate through results. However, I'm open to breaking that off for a second issue if you feel it's scope creep.
- I think the name of the method is a little confusing. I'd suggest
limitItems()- it's more concise, and makes it clear that we're applying a limit not just determining whether a limit should be there (which I'd expect to return abool) - Can't merge without test coverage for limits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4732
Describe your changes
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation