Skip to content

ensure benchmark files are updated in s3 - #218

Merged
abradley60 merged 1 commit into
mainfrom
update_test_ensure_branchmark_file_updates
Nov 4, 2026
Merged

abradley60 merged 1 commit into
mainfrom
update_test_ensure_branchmark_file_updates

Conversation

@abradley60

Copy link
Copy Markdown
Collaborator

Description

Ensures that the benchmark, or gold standard tiles are overwritten when UPDATE_BENCHMARK_TEST_DATA = True. Note, if the filenames themselves are changed, the existing benchmark files will need to be manually removed from the folder. The following action reduces confusion when files don't seem to update.

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Other (refactor, chore, etc.)

General Checklist

  • Automated tests pass
  • Related issue linked (if applicable)

isce3_rtc checklist (if this PR touches the isce3_rtc product)

  • Applicable
  • Not Applicable

Tests

  • Local tests pass pixi run test-isce3-rtc. More on testing is provided in the testing section of isce3_rtc.md
  • No changes to products when compared to benchmark / golden burst products (i.e. pixi run test-isce3-rtc-full-docker-workflow-run passes)

Product Versioning (Product Data has Changed)

If product data changes (for example, a bugfix in the ISCE3 software changes pixel locations), product_version should be bumped in S1_RTC_IW.yaml and S1_RTC_STATIC_IW.yaml. E.g. product_version is bumped from 1.0.0 to 1.0.1. This will be reflected in the output product filenames and metadata created by the pipeline.

  • S1_RTC_IW and S1_RTC_STATIC_IW versions have been bumped.
  • Benchmark data for tests have been updated (see Updating Test Data in isce3_rtc.md)
  • Versions do not need to be changed.

@abradley60
abradley60 merged commit a435948 into main Nov 4, 2026
2 checks passed
@abradley60
abradley60 deleted the update_test_ensure_branchmark_file_updates branch November 4, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants