Repository navigation
ensure benchmark files are updated in s3 - #218
Merged
Merged
Conversation
GA-prem-pradeep
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensures that the benchmark, or gold standard tiles are overwritten when
UPDATE_BENCHMARK_TEST_DATA = True. Note, if the filenames themselves are changed, the existing benchmark files will need to be manually removed from the folder. The following action reduces confusion when files don't seem to update.Type of change
General Checklist
isce3_rtc checklist (if this PR touches the isce3_rtc product)
Tests
pixi run test-isce3-rtc. More on testing is provided in the testing section of isce3_rtc.mdpixi run test-isce3-rtc-full-docker-workflow-runpasses)Product Versioning (Product Data has Changed)
If product data changes (for example, a bugfix in the ISCE3 software changes pixel locations),
product_versionshould be bumped in S1_RTC_IW.yaml and S1_RTC_STATIC_IW.yaml. E.g.product_versionis bumped from1.0.0to1.0.1. This will be reflected in the output product filenames and metadata created by the pipeline.