Updated workflow templating#656
Open
mranst wants to merge 349 commits into
Open
Conversation
* Initial commit * Update csh install instructions * Update installing_swell_csh_interactive.md * Update installing_swell_csh_interactive.md * fix order of steps * Update installing_swell_uv_venv.md
* Add eva yamls and suite config for cf * Fixes * Fix overlapping text * Remove increment file from clean patterns
mranst
added
the
passes tier1
Collaborator
Author
|
Bringing in a few more eyes to this PR now that we have some more people familiar with how Swell works. This is a complex PR that changes a lot of how swell is constructed, so please let me know if you have any questions or want a more detailed description on anything. I wrote some docs explaining how the new workflow templating works: https://github.com/GEOS-ESM/swell/blob/se/mranst/workflow_templating_redux2/docs/examples/templating_workflows.md. To summarize the advantages introduced by this PR:
Should we choose to merge this PR, I know it is bound to affect incoming PR's that are based on the old system. I am happy to assist in merging branches with this system to make this as painless as possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the most recent version of the concept of updating the workflow templating to use python. This approach should be more straightforward and easier to understand than the previous version, as it uses the same jinja templating in the graph section to make it easier to read (though it doesn't necessarily have to). This pr also merges the task_runtimes and task_questions objects used by the previous pr into one object for simplicity. I'm aiming for this approach to allow for greater independence of the tasks from the suite creation system, to allow generating configs for single tasks and having mock values for code tests for each task, but that's not ready to show off yet.
I still need to merge develop into this and update the docs, but I wanted to open this up as a draft