More IR optimisation rounds#7680
Conversation
|
e2e gas usage
| should_pass/language/u256/u256_operators (test.toml)::should_be_able_to_use_comparison_operators | 510 | 232 | 54.51% | e2e bytecode size
| should_pass/language/dereferenced_projection_reassignment (test.toml) | 168 | 72 | 57.14% | in lang gas usage
in lang bytecode size
o2 byte code
o2 gas usage
|
ironcev
left a comment
There was a problem hiding this comment.
This is a bit surprising. Intuitively, I've expected mostly improvements and very few regressions. The bytecode size increase is likely coming from more inlining. Numerous increases in gas usage are not that easy to explain at the first look.
With this number of regressions, their unpredictably looking distribution, and negative impact on o2, I rather wouldn't proceed with this PR and stay at two rounds that brought good gains.
Or at least, I wouldn't proceed until we analyze the regressions in more detail and see the impact on o2 benchmarks. It would definitely be a good additional insight into our IR optimizations and pipeling to understand the regressions. But on the other side I am not sure if it is worth the effort and we just close this PR without merging and proceed with other optimizations where we know we will surely have good gains.
Description
Now that optimisation passes converge, we increase the number of rounds.
Checklist
Breaking*orNew Featurelabels where relevant.