[TASK] #593: generate phpstan-compatible code (void return types, @var array<mixed>)#813
Draft
[TASK] #593: generate phpstan-compatible code (void return types, @var array<mixed>)#813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #593 — generates phpstan-compatible code for basic TYPO3 extensions.
: voidreturn types on setter methods: Fixed a parsing bug inClassFactory::buildClassMethodObject()that silently droppedvoid(and other primitive types) when reading method templates. PHP-Parser representsvoidas anIdentifiernode, notFullyQualified— the condition was too narrow.: voidreturn types on inject methods: Same root cause — existing inject methods with: voidlost their return type during round-trip parsing. Now preserved correctly.@var array<mixed>on$defaultOrderings: Added the missing PHPDoc annotation toRepository.phptso generated repositories pass phpstan without warnings.NodeFactory::buildMethodNode()to emit primitive return types asIdentifiernodes (output:void) instead ofFullyQualified(which would incorrectly output\void).Changes
Classes/Parser/ClassFactory.php— handleIdentifierreturn type nodesClasses/Parser/NodeFactory.php— emit primitive types asIdentifier, class types asFullyQualifiedResources/Private/CodeTemplates/Extbase/Classes/Domain/Repository/Repository.phpt— add@var array<mixed>to$defaultOrderingsTests/Unit/Parser/ClassFactoryTest.php— two new tests covering the parsing and output round-tripTest plan
buildClassMethodObjectParsesVoidReturnType— verifies: voidis parsed correctlybuildMethodNodeOutputsVoidReturnTypeWithoutLeadingBackslash— verifies output is: voidnot: \void🤖 Generated with Claude Code