[beesofts]

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
License	MIT

[Chris53897]

This was a blocker for a long time. Now Version 6.2 is available to support Symfony 8

"matthiasnoback/symfony-dependency-injection-test": "^4.0 || ^5.0 || ^6.0"",

Please change this versions as well.

        "symfony/console": "^5.4 || ^6.0 || ^7.0 || ^8.0",
        "symfony/phpunit-bridge": "^5.4 || ^6.0 || ^7.0 || ^8.0",
        "symfony/yaml": "^5.4 || ^6.0 || ^7.0 || ^8.0"

[Chris53897]

We need to add support for version 10 as well. Otherwise symfony/dependency-injection 8 is not installed.
"phpunit/phpunit": "^9.6 || ^10.0",

symfony/dependency-injection (v7.4.0)
https://packagist.org/packages/matthiasnoback/symfony-dependency-injection-test

[beesofts]

simple-phpunit fails for some reason. would it be possible to migrate to phpunit ?

[Chris53897]

I tried to find a way get it work. But could not find one yet.

Just changeing the test to run it with vendor/bin/phpunit makes the ci green.
https://github.com/Chris53897/FOSCKEditorBundle/actions/runs/19992315926

I think getting rid of symfony/phpunit-bridge for this bundle is fine, as it does probably not have a active future.
But i am not an maintainer.
@XWB WDYT?

[Chris53897]

symfony/demo removed symfony/phpunit-bridge
https://github.com/symfony/demo/pull/1549/files

symfony/symfony#59253 (comment)

[vdeville]

Hello @Chris53897 do you work on this PR ? Thanks

[Chris53897]

I am afraid there is nothing i can do here.
it would be great if @beesofts can change this line as he suggested.
https://github.com/FriendsOfSymfony/FOSCKEditorBundle/blob/2.x/.github/workflows/test.yaml#L41

After this a maintainer needs to have a look and merge/release it.

[beesofts]

nice the test has fail while downloading an external file... can a maintainer run again the job ?

[vdeville]

Thanks @beesofts all test passed !

[Chris53897]

One minor change could be to add .phpunit.cache to .gitignore or change the phpunit.xml.dist

[VincentLanglet]

Hi @XWB do you have time to take a look at this PR ? :)

[XWB]

Are there BC breaks or can we merge it into the 2.x branch?

[VincentLanglet]

Are there BC breaks or can we merge it into the 2.x branch?

src folder is not even modified ; so there is no BC break and can be merged on 2.x

[XWB]

Thanks, just wanted to be sure :)

[XWB]

Merged

[Chris53897]

Thanks