Repository navigation
fix(#628): Settings (4/4): restructure the settings drawer; translated server errors (#160) - #633
Merged
Merged
Conversation
Server errors reach the UI as codes with parameters and are shown translated. The booking-settings (#503) and task-list (#495) errors got their own codes, the weekday is named in the UI language, and the not-JSON message keeps its content type. Older E2E mocks that sent bare error text now send real codes and expect the translated text. Refs #628 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Security review (claude-fable-5-1): no blocking finding. Toast/innerHTML sinks escape; reflected params (detail) never reach the DOM; classify() fails closed to GENERIC; no new input trust, CSRF/auth untouched; e2e catalogue check and 404-shape tests have teeth. Minor: preferences 400s now log full stacks; RRULE detail echoed untruncated in JSON (pre-existing); //api paths lack a code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #628
Server errors reach the UI as codes with parameters and are shown translated. The booking-settings (#503) and task-list (#495) errors got their own codes, the weekday is named in the UI language, and the not-JSON message keeps its content type. Older E2E mocks that sent bare error text now send real codes and expect the translated text.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code