Skip to content

fix(#517): Mini month navigator and week numbers - #611

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-517
Oct 20, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-517

Conversation

@BeSovereign

@BeSovereign BeSovereign commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Refs #517

Unchanged #517 fix (sidebar mini month with marked event days, highlighted range and keyboard navigation; per-user ISO week numbers setting shown in month/week grids and the mini month). The rejected share-link E2E test (calendar.spec.js:1197) could not be reproduced: it passed 13 times on its own and in a complete calendar.spec.js run (251/251), and every class check in it covers code this change does not touch, so it is probably a timing flake (not proven); the #255 side-effect test passes.

Driver gates (measured, not claimed)

  • Suites: lint: 1 passed, 0 failed | node: 1973 passed, 0 failed | python: 194 passed, 0 failed | e2e: 322 passed, 0 failed
  • Red/green check on declared tests: e2e/mini_month.spec.js, server/test/issue517_week_numbers_preference.test.js, server/test/issue498_task_view_preference.test.js, server/test/issue509_secondary_timezone.test.js, server/test/issue108_search_kanban_empty_state.test.js, server/test/status_bar_view_counts.test.js
red/green output
RED without the change:
517-—-ISO-6c642-d-mini-month-kept-on-reload-chromium/trace.zip
    Usage:

        npx playwright show-trace test-results/mini_month-Issue-517-—-ISO-6c642-d-mini-month-kept-on-reload-chromium/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  3 failed
    [chromium] › e2e/mini_month.spec.js:31:3 › Issue #517 — mini month navigator › marks days with events outside the visible week and highlights the week shown 
    [chromium] › e2e/mini_month.spec.js:57:3 › Issue #517 — mini month navigator › arrow keys, Home/End and Page keys move through the days; Enter jumps there 
    [chromium] › e2e/mini_month.spec.js:105:3 › Issue #517 — ISO week numbers › switched on in the settings, shown in month, week and mini month, kept on reload 


GREEN with the change:
#106 — the status bar states loading, empty, error and count for every view
  ---
  duration_ms: 20.128721
  type: 'suite'
  ...
1..5
# tests 25
# suites 2
# pass 25
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 2299.555851


Running 3 tests using 1 worker

  ✓  1 [chromium] › e2e/mini_month.spec.js:31:3 › Issue #517 — mini month navigator › marks days with events outside the visible week and highlights the week shown (2.0s)
  ✓  2 [chromium] › e2e/mini_month.spec.js:57:3 › Issue #517 — mini month navigator › arrow keys, Home/End and Page keys move through the days; Enter jumps there (1.8s)
  ✓  3 [chromium] › e2e/mini_month.spec.js:105:3 › Issue #517 — ISO week numbers › switched on in the settings, shown in month, week and mini month, kept on reload (2.2s)

  3 passed (7.6s)

🤖 Generated with Claude Code

Unchanged #517 fix (sidebar mini month with marked event days, highlighted range and keyboard navigation; per-user ISO week numbers setting shown in month/week grids and the mini month). The rejected share-link E2E test (calendar.spec.js:1197) could not be reproduced: it passed 13 times on its own and in a complete calendar.spec.js run (251/251), and every class check in it covers code this change does not touch, so it is probably a timing flake (not proven); the #255 side-effect test passes.

Refs #517

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BeSovereign

Copy link
Copy Markdown
Contributor Author

Security review (claude-fable-5-1): no blocking finding. No auth, CSRF, injection or cache-leak defects in the touched code; strict boolean validation with tests that have teeth. Non-security: server/db.js:497 adds show_week_numbers only via CREATE TABLE IF NOT EXISTS, so pre-existing user_preferences tables lack the column and /api/preferences returns 500 (fail-closed availability regression, same gap as #509). Could not run the #255 import side-effect test (sandbox denied); the diff adds no require-time work.

@BeSovereign
BeSovereign merged commit 5362552 into main Oct 20, 2026
5 checks passed
@BeSovereign
BeSovereign deleted the fix/issue-517 branch October 20, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant