Repository navigation
fix(#517): Mini month navigator and week numbers - #611
Merged
Merged
Conversation
BeSovereign
force-pushed
the
fix/issue-517
branch
from
October 19, 2026 20:27
26e491f to
ad8fd38
Compare
Unchanged #517 fix (sidebar mini month with marked event days, highlighted range and keyboard navigation; per-user ISO week numbers setting shown in month/week grids and the mini month). The rejected share-link E2E test (calendar.spec.js:1197) could not be reproduced: it passed 13 times on its own and in a complete calendar.spec.js run (251/251), and every class check in it covers code this change does not touch, so it is probably a timing flake (not proven); the #255 side-effect test passes. Refs #517 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BeSovereign
force-pushed
the
fix/issue-517
branch
from
October 20, 2026 05:42
ad8fd38 to
2c536f9
Compare
Contributor
Author
|
Security review (claude-fable-5-1): no blocking finding. No auth, CSRF, injection or cache-leak defects in the touched code; strict boolean validation with tests that have teeth. Non-security: server/db.js:497 adds show_week_numbers only via CREATE TABLE IF NOT EXISTS, so pre-existing user_preferences tables lack the column and /api/preferences returns 500 (fail-closed availability regression, same gap as #509). Could not run the #255 import side-effect test (sandbox denied); the diff adds no require-time work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #517
Unchanged #517 fix (sidebar mini month with marked event days, highlighted range and keyboard navigation; per-user ISO week numbers setting shown in month/week grids and the mini month). The rejected share-link E2E test (calendar.spec.js:1197) could not be reproduced: it passed 13 times on its own and in a complete calendar.spec.js run (251/251), and every class check in it covers code this change does not touch, so it is probably a timing flake (not proven); the #255 side-effect test passes.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code