Skip to content

fix(#189): MEDIUM: the application view has no h1, and the visible heading order runs h4 → - #441

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-189
Oct 16, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-189

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #189

Changed #toolbar-title from h3 to h2 so the resting view exposes h1 'FreeShard Calendar' -> h2 '' with no skipped level (the drawer is already hidden and inert while closed). Added Playwright tests that read headings from Chromium's accessibility tree for the closed and open drawer, and flipped the old source-grep test, which asserted the wrong level h3; I kept that file rather than deleting it.

Driver gates (measured, not claimed)

  • Suites: lint: 1 passed, 0 failed | node: 1778 passed, 0 failed | python: 109 passed, 0 failed | e2e: 96 passed, 0 failed
  • Red/green check on declared tests: e2e/calendar.spec.js, server/test/issue189_heading_order.test.js
red/green output
RED without the change:
s row id=9ca3ed18-6a0e-4152-a665-0ecf7b5f4bb6: Stored value is not an AES-256-GCM value of this app
[WebServer] [db] Skipping undecryptable linked_accounts row id=9ca3ed18-6a0e-4152-a665-0ecf7b5f4bb6: Stored value is not an AES-256-GCM value of this app
[WebServer] [db] Skipping undecryptable linked_accounts row id=9ca3ed18-6a0e-4152-a665-0ecf7b5f4bb6: Stored value is not an AES-256-GCM value of this app
[WebServer] [db] Skipping undecryptable linked_accounts row id=9ca3ed18-6a0e-4152-a665-0ecf7b5f4bb6: Stored value is not an AES-256-GCM value of this app
[WebServer] [Webcal] Refresh failed for subscription 3a06fa7a-7afb-4dfd-b604-54521c6db6ea: Feed is not valid iCalendar: END:VCALENDAR missing (wrong content or truncated response)
[WebServer] [MSGraph OAuth] authorization was not granted


GREEN with the change:
s row id=50aaa88e-07bc-4a6d-aa91-e5ac229b1a4d: Stored value is not an AES-256-GCM value of this app
[WebServer] [db] Skipping undecryptable linked_accounts row id=50aaa88e-07bc-4a6d-aa91-e5ac229b1a4d: Stored value is not an AES-256-GCM value of this app
[WebServer] [db] Skipping undecryptable linked_accounts row id=50aaa88e-07bc-4a6d-aa91-e5ac229b1a4d: Stored value is not an AES-256-GCM value of this app
[WebServer] [db] Skipping undecryptable linked_accounts row id=50aaa88e-07bc-4a6d-aa91-e5ac229b1a4d: Stored value is not an AES-256-GCM value of this app
[WebServer] [Webcal] Refresh failed for subscription 2c7f2eb5-cae0-4a7f-aeed-37b6f98cca68: Feed is not valid iCalendar: END:VCALENDAR missing (wrong content or truncated response)
[WebServer] [MSGraph OAuth] authorization was not granted

🤖 Generated with Claude Code

Changed #toolbar-title from h3 to h2 so the resting view exposes h1 'FreeShard Calendar' -> h2 '<month>' with no skipped level (the drawer is already hidden and inert while closed). Added Playwright tests that read headings from Chromium's accessibility tree for the closed and open drawer, and flipped the old source-grep test, which asserted the wrong level h3; I kept that file rather than deleting it.

Refs #189

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant