Repository navigation
fix(#163): MEDIUM: errors are never announced, and a four-second toast is the only channel - #435
Merged
Merged
Conversation
Added role="alert" to all six inline form-error boxes (onboarding, event, account, webcal in index.html; edit-cal/add-cal in app.js), made the persistent error toast's close control a labelled keyboard-operable <button> ("Meldung schließen"), and removed the doubled 'Fehler: ' prefix on the calendar-delete and share-removal error toasts. Replaced the grep-only node test with six Playwright tests that force server failures and assert alert roles, toast persistence past 4 s, keyboard dismissal and the single prefix.
Refs #163
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #163
Added role="alert" to all six inline form-error boxes (onboarding, event, account, webcal in index.html; edit-cal/add-cal in app.js), made the persistent error toast's close control a labelled keyboard-operable ("Meldung schließen"), and removed the doubled 'Fehler: ' prefix on the calendar-delete and share-removal error toasts. Replaced the grep-only node test with six Playwright tests that force server failures and assert alert roles, toast persistence past 4 s, keyboard dismissal and the single prefix.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code