Repository navigation
fix(#112): MEDIUM: event chips and adjacent-month day numbers have no contrast floor - #429
Merged
Merged
Conversation
Month chips and week/day blocks now render title/time/location in --ink with the calendar colour only as a 4px left rail and a ≤30% tint over --surface (the agenda treatment), and adjacent-month cells drop the opacity in favour of a --bg background with --ink numbers, so all of them stay above 4.5:1 for any calendar colour in light and dark themes; the light-only ensureContrastFloor helper and its grep test are removed. This round fixes the E2E flake that failed the previous attempt: the #112 spec now waits for network idle after boot, because #app is shown before loadCalendars and a late store.set({calendars}) dropped the injected test calendars. Refs #112 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #112
Month chips and week/day blocks now render title/time/location in --ink with the calendar colour only as a 4px left rail and a ≤30% tint over --surface (the agenda treatment), and adjacent-month cells drop the opacity in favour of a --bg background with --ink numbers, so all of them stay above 4.5:1 for any calendar colour in light and dark themes; the light-only ensureContrastFloor helper and its grep test are removed. This round fixes the E2E flake that failed the previous attempt: the #112 spec now waits for network idle after boot, because #app is shown before loadCalendars and a late store.set({calendars}) dropped the injected test calendars.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code