Skip to content

sig_handler: use _exit() for SIGSEGV, keep exit() for clean shutdown #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pace17881 wants to merge 1 commit into from
Closed

sig_handler: use _exit() for SIGSEGV, keep exit() for clean shutdown #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/spnavd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,13 @@ static void sig_handler(int s)
break;

case SIGSEGV:
/* exit(), unlike _exit(), is not async-signal-safe: it runs the
* atexit(cleanup) handler below, which after a real segfault may
* itself operate on corrupted state (X11/socket/device teardown).
* Skip it and exit as directly as possible instead. */
logmsg(LOG_ERR, "Segmentation fault caught, trying to exit gracefully\n");
_exit(0);

case SIGINT:
case SIGTERM:
exit(0);
Expand Down