-
Notifications
You must be signed in to change notification settings - Fork 17
Use generated Dart client for deflock-router API #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -38,6 +38,8 @@ dependencies: | |||||||||||
| package_info_plus: ^8.0.0 | ||||||||||||
| csv: ^6.0.0 | ||||||||||||
| collection: ^1.18.0 | ||||||||||||
| deflock_router_client: | ||||||||||||
| path: ../FlockHopper/packages/deflock_router_client | ||||||||||||
|
||||||||||||
| path: ../FlockHopper/packages/deflock_router_client | |
| git: | |
| url: https://github.com/FlockHopper/FlockHopper.git | |
| path: packages/deflock_router_client | |
| ref: main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pair[1]/pair[0]assumes every coordinate entry has at least 2 elements. Previously malformed pairs were filtered out; now a short/invalid pair will throw (RangeError) and get wrapped as a misleading "Network error". Add validation (e.g., length check) and throw aRoutingExceptionwith a parse/invalid response message when coordinates are missing or malformed.