Skip to content

fix(synapse-core): retry upload session creation on transient network failures #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TippyFlitsUK wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(synapse-core): retry upload session creation on transient network failures #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
23c9534
fix(synapse-core): retry upload session creation on transient network…
Apr 9, 2026
ef04658
fix(synapse-core): only retry network errors, not HTTP errors
Apr 9, 2026
88ba685
test: increase timeout for batch error test to account for upload ses…
Apr 9, 2026
81c9fcc
test: increase timeouts for tests that trigger upload session retries
Apr 9, 2026
3122f8d
test: use HTTP 500 instead of network errors for upload session failu…
Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/synapse-core/src/sp/upload-streaming.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,14 @@ export async function uploadPieceStreaming(
): Promise<uploadPieceStreaming.OutputType> {
// Create upload session (POST /pdp/piece/uploads)
const createResponse = await request.post(new URL('pdp/piece/uploads', options.serviceURL), {
timeout: RETRY_CONSTANTS.MAX_RETRY_TIME,
timeout: 30_000,
signal: options.signal,
retry: {
retries: 2,
methods: ['post'],
minTimeout: 2_000,
shouldRetry: (ctx) => !HttpError.is(ctx.error),
},
Comment thread
TippyFlitsUK marked this conversation as resolved.
})
Comment on lines 49 to 58

if (createResponse.error) {
Expand Down
7 changes: 3 additions & 4 deletions packages/synapse-sdk/src/test/storage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,7 @@ describe('StorageService', () => {
http.post<Record<string, never>, { pieceCid: string }>(
'https://pdp.example.com/pdp/piece/uploads',
async () => {
return HttpResponse.error()
return HttpResponse.text('Internal Server Error', { status: 500 })
}
)
)
Expand Down Expand Up @@ -1137,9 +1137,8 @@ describe('StorageService', () => {
...Mocks.presets.basic,
}),
Mocks.PING(),
Mocks.pdp.postPieceHandler(testPieceCID, mockUuid, pdpOptions),
http.put('https://pdp.example.com/pdp/piece/upload/:uuid', async () => {
return HttpResponse.error()
http.post('https://pdp.example.com/pdp/piece/uploads', async () => {
return HttpResponse.text('Internal Server Error', { status: 500 })
})
)
Comment on lines 1139 to 1143
const synapse = new Synapse({ client, source: null })
Expand Down
2 changes: 1 addition & 1 deletion packages/synapse-sdk/src/test/synapse.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,7 @@ describe('Synapse', () => {
// Primary SP rejects upload
server.use(
http.post(`${pdpOptions.baseUrl}/pdp/piece/uploads`, async () => {
return HttpResponse.error()
return HttpResponse.text('Internal Server Error', { status: 500 })
})
)
try {
Expand Down