Fix stale claims in README and the csproj comments - #75
Merged
Conversation
Continues the sweep from #74 into the two places it did not cover. Everything below was checked against the code or the live site rather than eyeballed. README pointed at https://factoriotools-5jg.pages.dev/oil-field, which now 301-redirects to oilfieldplanner.factorygamefan.com. That line is fork-owned (17d3e68), so it now names the canonical host directly and readers skip a hop. README said "I captured 57 test blueprints". The corpus held 58 when that was written in 2023 and holds 61 now. Rather than revise a first-person historical statement to a number that will go stale again, it now says "a set of test blueprints" and points at small-list.txt for the current count. WebApp.csproj described the Swashbuckle CLI as net7-targeted. Its highest shipped target framework has been net8.0 since #63 moved the CLI 6.5.0 -> 6.9.0 - 6.5.0 really was net7.0. DOTNET_ROLL_FORWARD=Major is still required either way, since net8 to net10 is still a major roll-forward, so the note now says that and warns against assuming a future CLI bump makes it removable. CLAUDE.md located the tool manifest at ".config/dotnet-tools.json", which reads as the repo root and is not there. It is src/WebApp/.config/dotnet-tools.json. renovate.json5 already had the full path; the two now agree. Verified correct and deliberately left alone: README's "up to 16 different planning routines" is exactly right for default settings (4 pipe strategies x optimized/unoptimized x 2 beacon strategies), the three screenshots exist, the Score file does have a table at the bottom, /oil-field is a real route, the ImageSharp pin comment holds on every point including the Debug-only default surviving Directory.Build.props, and the OpenApi hold comment's two named schema filters really do use the APIs it says 2.x removes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wgci7Q7mw8PjJRHAaS78X2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #74's sweep into the two places it did not cover. Every claim below was checked against the code or the live site, not eyeballed.
Stale (fixed)
factoriotools-5jg.pages.devoilfieldplanner.factorygamefan.comWebApp.csproj.config/dotnet-tools.jsonsrc/WebApp/.config/dotnet-tools.jsonNotes on two of these:
The blueprint count is Joel's first-person prose from 2023, and this fork's
mainis the head of upstream PR #10, so edits land there. Rather than revise a historical statement to a number that goes stale on the next blueprint added, it now reads "a set of test blueprints" and linkssmall-list.txtfor the live count.The CLI target framework matters beyond pedantry: the roll-forward is still needed (net8 -> net10 is still major), so the note now says so explicitly and warns against assuming a future CLI bump makes
DOTNET_ROLL_FORWARDremovable without checking the package'stools/TFMs. 6.5.0 genuinely was net7.0 - the comment was right when written.Verified correct - no change
Listing these so this reads as an audit rather than a spot-check:
/oil-fieldis a real route inmain.tsand serves the SPA.ItemGroupgated onEnableVisualizer, the Debug-only default genuinely survivingDirectory.Build.props(itsEnableVisualizer=falseis scoped to theUseLuaSettingsgroup only), andVisualizer.csbehind#if ENABLE_VISUALIZER.OpenApiSchema.Nullableand theMicrosoft.OpenApi.Anytypes.linux-musl-x64withGenerateSwagger=false; tool manifest really is 6.9.0, matchingrenovate.json5.BlazorWebApp.csproj's only comment is commented-out MSBuild properties - dead config, not a claim.One thing found but not fixed
/oil-fieldreturns HTTP 404 while rendering correctly - Cloudflare Pages serves the build's404.html(a copy ofindex.html) for SPA routes. Harmless in a browser, but link checkers and crawlers see a 404 on the URL the README advertises. Pre-existing and unrelated to this PR, so raising it rather than changing deploy behaviour here.🤖 Generated with Claude Code
https://claude.ai/code/session_01Wgci7Q7mw8PjJRHAaS78X2