Further fix for Text Filtering when using Custom Blacklist#2206
Open
joomlabeat wants to merge 1 commit into
Open
Further fix for Text Filtering when using Custom Blacklist#2206joomlabeat wants to merge 1 commit into
joomlabeat wants to merge 1 commit into
Conversation
Following up a recent PR that attempted to fix the Filtering of textarea element when using Custom Blacklist, that was always defaulting to disregarding the Custom BL, this PR improves this, because the call the JFilterInput was still forcing to clean up based on the default blacklist. Helpful resources: - https://stackoverflow.com/a/42729709/1739313 - https://api.joomla.org/cms-3/classes/Joomla.CMS.Filter.InputFilter.html#method_getInstance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up the recent PR #2199 that attempted to fix the Filtering of Textarea element when using Custom Blacklist for Text Filters, this PR improves on top of that, because the call the JFilterInput call from inside the Worker is still forcing to clean up all tags of the default blacklist, because the param $xssAuto of the JFilterInput::getInstance() method gets the default value (1) which forces cleanup, instead of only cleaning the essentials.
Helpful resources: