Skip to content

bgpd: Don't mark nexthop as changed if a set next-hop unchanged is applied (backport #21445) #21527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
donaldsharp merged 2 commits into from
Apr 14, 2026

tests: Check if route-map with set nexthop unchanged does not prevent…

be602b7
Select commit
Loading
Failed to load commit list.
Merged

bgpd: Don't mark nexthop as changed if a set next-hop unchanged is applied (backport #21445) #21527

tests: Check if route-map with set nexthop unchanged does not prevent…
be602b7
Select commit
Loading
Failed to load commit list.
NetDEF CI Pull Requests Testing / [CI] Basic Tests failed Apr 14, 2026 in 0s

Basic Tests summary

➡️ Jobs queued: 0/48

➡️ Jobs in progress: 0/48

✖️ Jobs Failure: 8/48

AssertionError: Failed
assert Generated JSON diff error report:
 
 > $->192.168.100.101/32: expected has the following element at index 0 which is not present in output: 
 
 	{
 	    "protocol": "bgp",
 	    "selected": true,
 	    "destSelected": true,
 	    "installed": true,
 	    "internalNextHopNum": 2,
 	    "internalNextHopActiveNum": 2,
 	    "internalNextHopFibInstalledNum": 2,
 	    "nexthops": [
 	        {
 	            "fib": true,
 	            "ip": "10.0.0.2",
 	            "active": true,
 	            "weight": 255
 	        },
 	        {
 	            "fib": true,
 	            "ip": "10.0.0.3",
 	            "active": true,
 	            "weight": 255
 	        }
 	    ]
 	}
 
 	Closest match in output is at index 0 with the following errors: 
 
 	> $->192.168.100.101/32[0]: expected has key 'internalNextHopFibInstalledNum' which is not present in output
 	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 0 which is not present in output: 
 	
 		{
 		    "fib": true,
 		    "ip": "10.0.0.2",
 		    "active": true,
 		    "weight": 255
 		}
 	
 		Closest match in output is at index 0 with the following errors: 
 	
 		> $->192.168.100.101/32[0]->nexthops[0]->weight: output has element with value '254' but in expected it has value '255'
 	
 	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 1 which is not present in output: 
 	
 		{
 		    "fib": true,
 		    "ip": "10.0.0.3",
 		    "active": true,
 		    "weight": 255
 		}
 	
 		Closest match in output is at index 1 with the following errors: 
 	
 		> $->192.168.100.101/32[0]->nexthops[1]->weight: output has element with value '254' but in expected it has value '255'
E   AssertionError: Failed
   assert Generated JSON diff error report:
     
     > $->192.168.100.101/32: expected has the following element at index 0 which is not present in output: 
     
     	{
     	    "protocol": "bgp",
     	    "selected": true,
     	    "destSelected": true,
     	    "installed": true,
     	    "internalNextHopNum": 2,
     	    "internalNextHopActiveNum": 2,
     	    "internalNextHopFibInstalledNum": 2,
     	    "nexthops": [
     	        {
     	            "fib": true,
     	            "ip": "10.0.0.2",
     	            "active": true,
     	            "weight": 255
     	        },
     	        {
     	            "fib": true,
     	            "ip": "10.0.0.3",
     	            "active": true,
     	            "weight": 255
     	        }
     	    ]
     	}
     
     	Closest match in output is at index 0 with the following errors: 
     
     	> $->192.168.100.101/32[0]: expected has key 'internalNextHopFibInstalledNum' which is not present in output
     	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 0 which is not present in output: 
     	
     		{
     		    "fib": true,
     		    "ip": "10.0.0.2",
     		    "active": true,
     		    "weight": 255
     		}
     	
     		Closest match in output is at index 0 with the following errors: 
     	
     		> $->192.168.100.101/32[0]->nexthops[0]->weight: output has element with value '254' but in expected it has value '255'
     	
     	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 1 which is not present in output: 
     	
     		{
     		    "fib": true,
     		    "ip": "10.0.0.3",
     		    "active": true,
     		    "weight": 255
     		}
     	
     		Closest match in output is at index 1 with the following errors: 
     	
     		> $->192.168.100.101/32[0]->nexthops[1]->weight: output has element with value '254' but in expected it has value '255'

AssertionError: Failed
assert Generated JSON diff error report:
 
 > $->192.168.100.101/32: expected has the following element at index 0 which is not present in output: 
 
 	{
 	    "protocol": "bgp",
 	    "selected": true,
 	    "destSelected": true,
 	    "installed": true,
 	    "internalNextHopNum": 2,
 	    "internalNextHopActiveNum": 2,
 	    "internalNextHopFibInstalledNum": 2,
 	    "nexthops": [
 	        {
 	            "fib": true,
 	            "ip": "10.0.0.2",
 	            "active": true,
 	            "weight": 255
 	        },
 	        {
 	            "fib": true,
 	            "ip": "10.0.0.3",
 	            "active": true,
 	            "weight": 255
 	        }
 	    ]
 	}
 
 	Closest match in output is at index 0 with the following errors: 
 
 	> $->192.168.100.101/32[0]: expected has key 'internalNextHopFibInstalledNum' which is not present in output
 	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 0 which is not present in output: 
 	
 		{
 		    "fib": true,
 		    "ip": "10.0.0.2",
 		    "active": true,
 		    "weight": 255
 		}
 	
 		Closest match in output is at index 0 with the following errors: 
 	
 		> $->192.168.100.101/32[0]->nexthops[0]->weight: output has element with value '254' but in expected it has value '255'
 	
 	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 1 which is not present in output: 
 	
 		{
 		    "fib": true,
 		    "ip": "10.0.0.3",
 		    "active": true,
 		    "weight": 255
 		}
 	
 		Closest match in output is at index 1 with the following errors: 
 	
 		> $->192.168.100.101/32[0]->nexthops[1]->weight: output has element with value '254' but in expected it has value '255'
E   AssertionError: Failed
   assert Generated JSON diff error report:
     
     > $->192.168.100.101/32: expected has the following element at index 0 which is not present in output: 
     
     	{
     	    "protocol": "bgp",
     	    "selected": true,
     	    "destSelected": true,
     	    "installed": true,
     	    "internalNextHopNum": 2,
     	    "internalNextHopActiveNum": 2,
     	    "internalNextHopFibInstalledNum": 2,
     	    "nexthops": [
     	        {
     	            "fib": true,
     	            "ip": "10.0.0.2",
     	            "active": true,
     	            "weight": 255
     	        },
     	        {
     	            "fib": true,
     	            "ip": "10.0.0.3",
     	            "active": true,
     	            "weight": 255
     	        }
     	    ]
     	}
     
     	Closest match in output is at index 0 with the following errors: 
     
     	> $->192.168.100.101/32[0]: expected has key 'internalNextHopFibInstalledNum' which is not present in output
     	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 0 which is not present in output: 
     	
     		{
     		    "fib": true,
     		    "ip": "10.0.0.2",
     		    "active": true,
     		    "weight": 255
     		}
     	
     		Closest match in output is at index 0 with the following errors: 
     	
     		> $->192.168.100.101/32[0]->nexthops[0]->weight: output has element with value '254' but in expected it has value '255'
     	
     	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 1 which is not present in output: 
     	
     		{
     		    "fib": true,
     		    "ip": "10.0.0.3",
     		    "active": true,
     		    "weight": 255
     		}
     	
     		Closest match in output is at index 1 with the following errors: 
     	
     		> $->192.168.100.101/32[0]->nexthops[1]->weight: output has element with value '254' but in expected it has value '255'

AssertionError: Partial links towards spine1 down verification failed
assert False
E   AssertionError: Partial links towards spine1 down verification failed
   assert False

AssertionError: Failed
assert Generated JSON diff error report:
 
 > $->192.168.100.101/32: expected has the following element at index 0 which is not present in output: 
 
 	{
 	    "protocol": "bgp",
 	    "selected": true,
 	    "destSelected": true,
 	    "installed": true,
 	    "internalNextHopNum": 2,
 	    "internalNextHopActiveNum": 2,
 	    "internalNextHopFibInstalledNum": 2,
 	    "nexthops": [
 	        {
 	            "fib": true,
 	            "ip": "10.0.0.2",
 	            "active": true,
 	            "weight": 255
 	        },
 	        {
 	            "fib": true,
 	            "ip": "10.0.0.3",
 	            "active": true,
 	            "weight": 255
 	        }
 	    ]
 	}
 
 	Closest match in output is at index 0 with the following errors: 
 
 	> $->192.168.100.101/32[0]: expected has key 'internalNextHopFibInstalledNum' which is not present in output
 	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 0 which is not present in output: 
 	
 		{
 		    "fib": true,
 		    "ip": "10.0.0.2",
 		    "active": true,
 		    "weight": 255
 		}
 	
 		Closest match in output is at index 0 with the following errors: 
 	
 		> $->192.168.100.101/32[0]->nexthops[0]->weight: output has element with value '254' but in expected it has value '255'
 	
 	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 1 which is not present in output: 
 	
 		{
 		    "fib": true,
 		    "ip": "10.0.0.3",
 		    "active": true,
 		    "weight": 255
 		}
 	
 		Closest match in output is at index 1 with the following errors: 
 	
 		> $->192.168.100.101/32[0]->nexthops[1]->weight: output has element with value '254' but in expected it has value '255'
E   AssertionError: Failed
   assert Generated JSON diff error report:
     
     > $->192.168.100.101/32: expected has the following element at index 0 which is not present in output: 
     
     	{
     	    "protocol": "bgp",
     	    "selected": true,
     	    "destSelected": true,
     	    "installed": true,
     	    "internalNextHopNum": 2,
     	    "internalNextHopActiveNum": 2,
     	    "internalNextHopFibInstalledNum": 2,
     	    "nexthops": [
     	        {
     	            "fib": true,
     	            "ip": "10.0.0.2",
     	            "active": true,
     	            "weight": 255
     	        },
     	        {
     	            "fib": true,
     	            "ip": "10.0.0.3",
     	            "active": true,
     	            "weight": 255
     	        }
     	    ]
     	}
     
     	Closest match in output is at index 0 with the following errors: 
     
     	> $->192.168.100.101/32[0]: expected has key 'internalNextHopFibInstalledNum' which is not present in output
     	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 0 which is not present in output: 
     	
     		{
     		    "fib": true,
     		    "ip": "10.0.0.2",
     		    "active": true,
     		    "weight": 255
     		}
     	
     		Closest match in output is at index 0 with the following errors: 
     	
     		> $->192.168.100.101/32[0]->nexthops[0]->weight: output has element with value '254' but in expected it has value '255'
     	
     	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 1 which is not present in output: 
     	
     		{
     		    "fib": true,
     		    "ip": "10.0.0.3",
     		    "active": true,
     		    "weight": 255
     		}
     	
     		Closest match in output is at index 1 with the following errors: 
     	
     		> $->192.168.100.101/32[0]->nexthops[1]->weight: output has element with value '254' but in expected it has value '255'

AssertionError: Partial links towards spine1 down verification failed
assert False
E   AssertionError: Partial links towards spine1 down verification failed
   assert False

AssertionError: Failed
assert Generated JSON diff error report:
 
 > $->192.168.100.101/32: expected has the following element at index 0 which is not present in output: 
 
 	{
 	    "protocol": "bgp",
 	    "selected": true,
 	    "destSelected": true,
 	    "installed": true,
 	    "internalNextHopNum": 2,
 	    "internalNextHopActiveNum": 2,
 	    "internalNextHopFibInstalledNum": 2,
 	    "nexthops": [
 	        {
 	            "fib": true,
 	            "ip": "10.0.0.2",
 	            "active": true,
 	            "weight": 255
 	        },
 	        {
 	            "fib": true,
 	            "ip": "10.0.0.3",
 	            "active": true,
 	            "weight": 255
 	        }
 	    ]
 	}
 
 	Closest match in output is at index 0 with the following errors: 
 
 	> $->192.168.100.101/32[0]: expected has key 'internalNextHopFibInstalledNum' which is not present in output
 	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 0 which is not present in output: 
 	
 		{
 		    "fib": true,
 		    "ip": "10.0.0.2",
 		    "active": true,
 		    "weight": 255
 		}
 	
 		Closest match in output is at index 0 with the following errors: 
 	
 		> $->192.168.100.101/32[0]->nexthops[0]->weight: output has element with value '254' but in expected it has value '255'
 	
 	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 1 which is not present in output: 
 	
 		{
 		    "fib": true,
 		    "ip": "10.0.0.3",
 		    "active": true,
 		    "weight": 255
 		}
 	
 		Closest match in output is at index 1 with the following errors: 
 	
 		> $->192.168.100.101/32[0]->nexthops[1]->weight: output has element with value '254' but in expected it has value '255'
E   AssertionError: Failed
   assert Generated JSON diff error report:
     
     > $->192.168.100.101/32: expected has the following element at index 0 which is not present in output: 
     
     	{
     	    "protocol": "bgp",
     	    "selected": true,
     	    "destSelected": true,
     	    "installed": true,
     	    "internalNextHopNum": 2,
     	    "internalNextHopActiveNum": 2,
     	    "internalNextHopFibInstalledNum": 2,
     	    "nexthops": [
     	        {
     	            "fib": true,
     	            "ip": "10.0.0.2",
     	            "active": true,
     	            "weight": 255
     	        },
     	        {
     	            "fib": true,
     	            "ip": "10.0.0.3",
     	            "active": true,
     	            "weight": 255
     	        }
     	    ]
     	}
     
     	Closest match in output is at index 0 with the following errors: 
     
     	> $->192.168.100.101/32[0]: expected has key 'internalNextHopFibInstalledNum' which is not present in output
     	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 0 which is not present in output: 
     	
     		{
     		    "fib": true,
     		    "ip": "10.0.0.2",
     		    "active": true,
     		    "weight": 255
     		}
     	
     		Closest match in output is at index 0 with the following errors: 
     	
     		> $->192.168.100.101/32[0]->nexthops[0]->weight: output has element with value '254' but in expected it has value '255'
     	
     	> $->192.168.100.101/32[0]->nexthops: expected has the following element at index 1 which is not present in output: 
     	
     		{
     		    "fib": true,
     		    "ip": "10.0.0.3",
     		    "active": true,
     		    "weight": 255
     		}
     	
     		Closest match in output is at index 1 with the following errors: 
     	
     		> $->192.168.100.101/32[0]->nexthops[1]->weight: output has element with value '254' but in expected it has value '255'

AssertionError: Partial links towards spine1 down verification failed
assert False
E   AssertionError: Partial links towards spine1 down verification failed
   assert False

✔️ Jobs Success: 40/48

Details at https://ci1.netdef.org/browse/FRR-PULLREQ3-16344.

View more details on NetDEF CI Pull Requests Testing