bgpd: initialise nh_flag attribute

[fdumontet6WIND]

in "leak_update" function
nh_flag is not initialized when nexthop is valid at route creation.

[greptile-apps]

Greptile Summary

This PR initializes the BGP_ATTR_NH_VALID flag on new->attr->nh_flags in the leak_update function's new-route creation path, mirroring the pattern already used in the vpn-to-vrf update path (bgp_mplsvpn.c:2488). The fix is logically sound, but line 1445 contains a typo — nh_flag instead of nh_flags — which will prevent the code from compiling entirely.

Confidence Score: 4/5

Not safe to merge until the nh_flag → nh_flags typo is corrected; it is a compile-time error.

A single one-character typo (nh_flag vs nh_flags) causes a compile error that blocks the entire build. The fix intent is correct and the change is minimal, so once the typo is resolved the PR should be ready.

bgpd/bgp_mplsvpn.c line 1445

Important Files Changed

Filename	Overview
bgpd/bgp_mplsvpn.c	Adds BGP_ATTR_NH_VALID flag in leak_update for newly created routes, but contains a typo (nh_flag vs nh_flags) that causes a compile error.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[leak_update called] --> B{Existing bpi found?}
    B -- Yes --> C[Replace bpi->attr with new_attr]
    C --> D{leak_update_nexthop_valid?}
    D -- Valid --> E[SET BGP_PATH_VALID on bpi->flags]
    D -- Invalid --> F[UNSET BGP_PATH_VALID on bpi->flags]
    E --> G[⚠️ nh_flags NOT updated on bpi->attr in update path]
    B -- No --> H[Create new bgp_path_info via info_make]
    H --> I{leak_update_nexthop_valid?}
    I -- Valid --> J[SET BGP_PATH_VALID on new->flags]
    J --> K["SET_FLAG(new->attr->nh_flags, BGP_ATTR_NH_VALID) ← this PR (typo: nh_flag)"]
    I -- Invalid --> L[UNSET BGP_PATH_VALID on new->flags]

Loading

Prompt To Fix All With AI

This is a comment left during a code review.
Path: bgpd/bgp_mplsvpn.c
Line: 1445

Comment:
**Typo: `nh_flag` should be `nh_flags`**

The struct field is `nh_flags` (`uint8_t nh_flags` in `bgp_attr.h:141`), not `nh_flag`. This typo causes a compile-time error — the field `nh_flag` does not exist on `struct attr`, so this line will produce a "no member named 'nh_flag'" error. Every other usage in the codebase (e.g. `bgp_mplsvpn.c:2488`, `bgp_routemap.c:4218`, `bgp_attr.c:1094`) correctly uses `nh_flags`.

```suggestion
		SET_FLAG(new->attr->nh_flags, BGP_ATTR_NH_VALID);
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "bgpd: initialise nh_flag attribute" | Re-trigger Greptile}

[greptile-apps]

Typo: nh_flag should be nh_flags

The struct field is nh_flags (uint8_t nh_flags in bgp_attr.h:141), not nh_flag. This typo causes a compile-time error — the field nh_flag does not exist on struct attr, so this line will produce a "no member named 'nh_flag'" error. Every other usage in the codebase (e.g. bgp_mplsvpn.c:2488, bgp_routemap.c:4218, bgp_attr.c:1094) correctly uses nh_flags.

Suggested change

	SET_FLAG(new->attr->nh_flag, BGP_ATTR_NH_VALID);
	SET_FLAG(new->attr->nh_flags, BGP_ATTR_NH_VALID);

Prompt To Fix With AI

This is a comment left during a code review.
Path: bgpd/bgp_mplsvpn.c
Line: 1445

Comment:
**Typo: `nh_flag` should be `nh_flags`**

The struct field is `nh_flags` (`uint8_t nh_flags` in `bgp_attr.h:141`), not `nh_flag`. This typo causes a compile-time error — the field `nh_flag` does not exist on `struct attr`, so this line will produce a "no member named 'nh_flag'" error. Every other usage in the codebase (e.g. `bgp_mplsvpn.c:2488`, `bgp_routemap.c:4218`, `bgp_attr.c:1094`) correctly uses `nh_flags`.

```suggestion
		SET_FLAG(new->attr->nh_flags, BGP_ATTR_NH_VALID);
```

How can I resolve this? If you propose a fix, please make it concise.

[ton31337]

Is this BGP_ATTR_NH_VALID flag used anywhere at all in the code?