Skip to content

ospfd: add validation in several places before accessing message bodies (backport #21303) #21495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mergify wants to merge 1 commit into
base: stable/10.2
Choose a base branch
from

ospfd: add validation in several places before accessing

cb75409
Select commit
Loading
Failed to load commit list.
Open

ospfd: add validation in several places before accessing message bodies (backport #21303) #21495

ospfd: add validation in several places before accessing
cb75409
Select commit
Loading
Failed to load commit list.
NetDEF CI Pull Requests Testing / [CI] Basic Tests failed Apr 10, 2026 in 0s

Basic Tests summary

➡️ Jobs queued: 0/48

➡️ Jobs in progress: 0/48

✖️ Jobs Failure: 10/48

AssertionError: --- Actual Route-map output
 +++ Expected Route-map output
 @@ -38,6 +38,29 @@
   
  0
   
 +(
 +X
 + 
 +m
 +i
 +l
 +l
 +i
 +s
 +e
 +c
 +o
 +n
 +d
 +s
 + 
 +t
 +o
 +t
 +a
 +l
 +)
 + 
  O
  p
  t
 @@ -114,6 +137,29 @@
  d
   
  0
 + 
 +(
 +X
 + 
 +m
 +i
 +l
 +l
 +i
 +s
 +e
 +c
 +o
 +n
 +d
 +s
 + 
 +t
 +o
 +t
 +a
 +l
 +)
  
   
   
assert False
E   AssertionError: --- Actual Route-map output
     +++ Expected Route-map output
     @@ -38,6 +38,29 @@
       
      0
       
     +(
     +X
     + 
     +m
     +i
     +l
     +l
     +i
     +s
     +e
     +c
     +o
     +n
     +d
     +s
     + 
     +t
     +o
     +t
     +a
     +l
     +)
     + 
      O
      p
      t
     @@ -114,6 +137,29 @@
      d
       
      0
     + 
     +(
     +X
     + 
     +m
     +i
     +l
     +l
     +i
     +s
     +e
     +c
     +o
     +n
     +d
     +s
     + 
     +t
     +o
     +t
     +a
     +l
     +)
      
       
       
   assert False

AssertionError: Failed to see retained stale routes on R1
assert Generated JSON diff error report:
 
 > $->paths: expected has the following element at index 0 which is not present in output: 
 
 	{
 	    "stale": true,
 	    "valid": true
 	}
 
 	Closest match in output is at index 0 with the following errors: 
 
 	> $->paths[0]: expected has key 'stale' which is not present in output
E   AssertionError: Failed to see retained stale routes on R1
   assert Generated JSON diff error report:
     
     > $->paths: expected has the following element at index 0 which is not present in output: 
     
     	{
     	    "stale": true,
     	    "valid": true
     	}
     
     	Closest match in output is at index 0 with the following errors: 
     
     	> $->paths[0]: expected has key 'stale' which is not present in output

AssertionError: 'r1' wrong number of route nexthops
assert [1, 1, 1, 1, 2, 2, 3, 3, 3] == [1, 1, 1, 1, 2, 3, 3, 3, 3]
 
 At index 5 diff: 2 != 3
 
 Full diff:
   [
       1,
       1,
       1,
       1,
       2,
 -     3,
 ?     ^
 +     2,
 ?     ^
       3,
       3,
       3,
   ]
E   AssertionError: 'r1' wrong number of route nexthops
   assert [1, 1, 1, 1, 2, 2, 3, 3, 3] == [1, 1, 1, 1, 2, 3, 3, 3, 3]
     
     At index 5 diff: 2 != 3
     
     Full diff:
       [
           1,
           1,
           1,
           1,
           2,
     -     3,
     ?     ^
     +     2,
     ?     ^
           3,
           3,
           3,
       ]

NameError: name 'step' is not defined
E   NameError: name 'step' is not defined

AssertionError: Partial links towards spine1 down verification failed
assert False
E   AssertionError: Partial links towards spine1 down verification failed
   assert False

NameError: name 'step' is not defined
E   NameError: name 'step' is not defined

NameError: name 'step' is not defined
E   NameError: name 'step' is not defined

NameError: name 'step' is not defined
E   NameError: name 'step' is not defined

AssertionError: Partial links towards spine1 down verification failed
assert False
E   AssertionError: Partial links towards spine1 down verification failed
   assert False

AssertionError: Partial links towards spine1 down verification failed
assert False
E   AssertionError: Partial links towards spine1 down verification failed
   assert False

✔️ Jobs Success: 38/48

Details at https://ci1.netdef.org/browse/FRR-PULLREQ3-16272.

View more details on NetDEF CI Pull Requests Testing