Major refactor of p(x,O) calculations#28
Merged
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
bandersen441
approved these changes
Jun 11, 2026
bandersen441
left a comment
bandersen441
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Confirmed that this fixes step_size and p(x|U) bugs (provided ssize = max_box / 60, which appears to be true). The exponential prior normalization is not fixed. But I will make a separate pull request for that.
Contributor
Author
|
Also now includes the normalization bug that @bandersen441 discovered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And related speed-ups
Claude inspired throughout
New tests and docs too