Replace deprecated UIScreen.mainScreen in FLEXMacros.h#739
Open
matrush wants to merge 3 commits into
Open
Conversation
Adds a FLEXScreen() helper that resolves a UIScreen instance through the application's connected scene context, preferring the foreground-active window scene. UIScreen.mainScreen is deprecated in iOS 26.
…rM9M Replace deprecated UIScreen.mainScreen in FLEXMacros.h
ryanolsonk
approved these changes
May 12, 2026
Member
ryanolsonk
left a comment
ryanolsonk
left a comment
There was a problem hiding this comment.
nit to add braces, otherwise lgtm. Thanks for doing this!
Curly
NSExceptional
requested changes
May 18, 2026
| /// since +[UIScreen mainScreen] is deprecated in iOS 26. | ||
| NS_INLINE UIScreen *FLEXScreen(void) { | ||
| UIScreen *fallback = nil; | ||
| for (UIScene *scene in UIApplication.sharedApplication.connectedScenes) { |
Collaborator
There was a problem hiding this comment.
Wait a second, connectedScenes is only available in iOS 13+. FLEX supports iOS 9. This will crash on anything below iOS 13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
FLEXScreen()helper that resolves aUIScreeninstance through the application's connected scene context, preferring the foreground-active window scene.UIScreen.mainScreenis deprecated in iOS 26.