Skip to content

chore: modernize bun dev stack - #120

Merged
FIL1994 merged 7 commits into
masterfrom
chore/modernize-bun-dev-stack
Jun 1, 2026
Merged

FIL1994 merged 7 commits into
masterfrom
chore/modernize-bun-dev-stack

Conversation

@FIL1994

@FIL1994 FIL1994 commented Jun 1, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • migrate the dev toolchain to Bun with a text bun.lock and updated package scripts
  • update lint/build/test/storybook dependencies and configs for the modern stack
  • refresh CI workflows and add the modernization roadmap documentation

Validation

  • bun run ci

Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 5 additional findings in Devin Review.

Open in Devin Review

});

// expect(bottomRightMock).toHaveBeenCalled();
expect(bottomRightMock).toHaveBeenCalled();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Test assertion will fail: onKeyPress is removed in React 19 but Parallax component still uses it

The PR uncomments the assertion expect(bottomRightMock).toHaveBeenCalled() at line 76, but this assertion will fail. The Parallax component (src/experimentals/Parallax.tsx:56) uses onKeyPress for keyboard event handling, and React 19 (locked at react@19.2.6 in bun.lock) removed onKeyPress support entirely. The test fires fireEvent.keyPress, fireEvent.keyDown, and fireEvent.keyUp, but since the component only binds onKeyPress (not onKeyDown/onKeyUp), none of these events will trigger the mock callback. The assertion was previously commented out (likely because this was already known to be broken), and uncommenting it without migrating the component from onKeyPress to onKeyDown will cause the test suite to fail.

Prompt for agents
The test assertion at src/experimentals/Parallax.test.tsx:76 expects bottomRightMock to have been called, but the Parallax component (src/experimentals/Parallax.tsx) uses onKeyPress which was removed in React 19. The fix requires two coordinated changes:

1. In src/experimentals/Parallax.tsx, replace all onKeyPress handlers with onKeyDown. For example, change onKeyPress={bottomRight && onEnter(bottomRight)} to onKeyDown={bottomRight && onEnter(bottomRight)}. This applies to all four corner elements (lines 35, 42, 49, 56).

2. In src/experimentals/Parallax.test.tsx, the test can then rely on fireEvent.keyDown to trigger the mock. The fireEvent.keyPress call can be removed since it tests a deprecated API.

The same onKeyPress to onKeyDown migration should also be applied to src/components/Pagination.tsx (lines 44, 63, 75) and src/components/ControlledTab.tsx (line 43) which have the same issue.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@netlify

netlify Bot commented Jun 1, 2026

Copy link
Copy Markdown

✅ Deploy Preview for spectre-react ready!

Name Link
🔨 Latest commit ccf0536
🔍 Latest deploy log https://app.netlify.com/projects/spectre-react/deploys/6a1e199d9edc5000089dc702
😎 Deploy Preview https://deploy-preview-120--spectre-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@FIL1994
FIL1994 merged commit 9286aa5 into master Jun 1, 2026
11 checks passed
@FIL1994
FIL1994 deleted the chore/modernize-bun-dev-stack branch June 1, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant