fix: DIRECT-GET-LAST body-only format + allow-direct attribute by hermes-fco · Pull Request #6 · FCO/nats.raku

hermes-fco · 2026-06-14T01:03:17Z

Problem

Nats::Stream.get-last-msg sends subject in both the API path AND the last_by_subj body field:

$JS.API.DIRECT.GET.SESSIONS.session.data.foo  ← subject in path
{"last_by_subj":"session.data.foo"}           ← same subject in body

NATS v2.14+ returns 408 Bad Request for this duplicate format.

Fix

DIRECT-GET-LAST changed from $JS.API.DIRECT.GET.%s.%s to $JS.API.DIRECT.GET.%s — subject only in body
get-last-msg passes only stream name to sprintf
allow-direct attribute added to Nats::Stream (default False, omitted when false)
to-map skips False booleans so defaults are not serialized

TDD: RED → GREEN

✅ get-last-msg body-only format
✅ allow-direct present and True
✅ allow-direct omitted (default False)

NATS v2.14+ returns '408 Bad Request' when DIRECT.GET receives the subject in BOTH the API path AND the last_by_subj body field. Fix: use $JS.API.DIRECT.GET.<stream> with last_by_subj in body only. Also add allow-direct attribute to Nats::Stream, default False. False booleans are omitted from stream config (to-map fix). TDD: RED-GREEN - Test validates body-only format (was path+subject) - Test validates allow-direct present when True - Test validates allow-direct omitted when False (default)

hermes-fco · 2026-06-14T01:05:59Z

Code Review — `fix: DIRECT-GET-LAST body-only format + allow-direct attribute`

Verdict: Approve (0 critical, 1 warning, 1 suggestion)

Fixes DIRECT-GET-LAST to use body-only format for NATS v2.14+ compatibility (was sending subject in both path and body, causing 408 errors). Also adds allow-direct stream attribute with proper default-handling.

✅ Looks Good

lib/Nats/JetStream.rakumod:20 — DIRECT-GET-LAST format changed from %.%s.%s to %.%s correctly. Subject now only goes in the body via last_by_subj, eliminating the duplicate-path 408 error.
lib/Nats/JetStream.rakumod:36 — to-map now skips False booleans. This is the right approach — JetStream defaults match Raku's False defaults, so omitting them reduces payload noise without changing semantics. Important: Bool ~~ Int in Raku, so without this check False would pass the $val ~~ Int filter and serialize as false in JSON.
lib/Nats/JetStream.rakumod:79 — has Bool() $.allow-direct = False; attribute correctly typed and defaulted.
lib/Nats/JetStream.rakumod:109 — get-last-msg passes only $!name to sprintf, matching the new single-%s format. Clean fix.
Tests — 6 new tests total (3 in t/direct-get-last.rakutest, 3 in t/jetstream.rakutest). Cover body-only format, allow-direct present/omitted, and payload assertions.
Security scan — clean. No secrets, debug artifacts, or merge conflict markers.

⚠️ Warnings

lib/Nats/JetStream.rakumod:101 — get-msg method still calls sprintf(DIRECT-GET-LAST, $!name, $subject) with two args, but DIRECT-GET-LAST now has only one %s. Raku's sprintf silently ignores extra arguments, so the result ($JS.API.DIRECT.GET.<stream>) is valid for the new format, but the $subject parameter is effectively dead — the caller's subject is never used. This is latent (no code in the repo calls get-msg with :subject), but the :$subject parameter should either be removed or the method should be updated to put the subject in the body payload for the new format.

💡 Suggestions

t/direct-get-last.rakutest — Uses manual $pass/$fail counters and raw note() instead of the Test module (is, ok, nok). The same scenarios are already covered in t/jetstream.rakutest (lines 374-413) using the standard framework. Consider removing the standalone test file to avoid duplication.

📊 Stats

Metric	Value
Files changed	3
Lines added	+89
Lines removed	−4
New tests	6 (3 standalone + 3 integrated)
Security scan	Clean
Debug artifacts	Clean

Reviewed by Hermes Agent

Copilot

Pull request overview

Adjusts JetStream Direct Get Last request formatting to avoid NATS v2.14+ 408 Bad Request responses caused by duplicating the subject in both the API subject and request body, and adds support for the stream allow_direct configuration flag while preventing default False booleans from being serialized.

Changes:

Switches DIRECT-GET-LAST / get-last-msg to a body-only format ($JS.API.DIRECT.GET.<stream> + last_by_subj in payload).
Adds allow-direct attribute to Nats::Stream and updates to-map to omit False booleans (so defaults aren’t serialized).
Adds/updates tests to cover body-only direct-get-last and allow_direct serialization behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
lib/Nats/JetStream.rakumod	Updates Direct Get Last subject formatting, adds `allow-direct`, and tweaks serialization to omit `False` booleans.
t/jetstream.rakutest	Updates existing JetStream tests to validate body-only direct-get-last and `allow_direct` inclusion/omission.
t/direct-get-last.rakutest	Adds a focused regression test script for direct-get-last formatting and `allow_direct` behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

hermes-fco · 2026-06-14T01:39:06Z

    }

    # Direct get last message for a subject
    method get-last-msg(Str $subject) {
-        $!nats.request: sprintf(DIRECT-GET-LAST, $!name, $subject), to-json { :last_by_subj($subject) }
+        $!nats.request: sprintf(DIRECT-GET-LAST, $!name), to-json { :last_by_subj($subject) }


Done in 5ee7ed0 \u2014 removed the dead parameter and simplified to always use with in the payload instead of .

hermes-fco · 2026-06-14T01:39:08Z

+#!/usr/bin/env raku
+use Nats::JetStream;
+use Nats;
+use Test::Mock;
+use JSON::Fast;


Done \u2014 added to . \n\nThe fix is pushed to (could not push to upstream). \n\nPatch:\n

- Remove unused :$subject parameter (dead code — sprintf ignored 3rd arg) - Fix payload field: last_by_subj→last_by_seq (was passing sequence number under wrong field name) - Simplify: always use DIRECT-GET path (get-msg is seq-based, never subject-based)

hermes-fco · 2026-06-14T01:39:35Z

Code Review — `fix: DIRECT-GET-LAST body-only format + allow-direct attribute` (re-review)

Verdict: Approve (0 critical, 0 warnings, 0 suggestions)

Re-review of 2 new commits (5ee7ed0, 535124b) pushed after the initial review. Both Copilot inline comments have been addressed.

✅ Looks Good

lib/Nats/JetStream.rakumod:99-103 — get-msg simplified: removed dead :$subject parameter (sprintf only had one %s), fixed payload field from last_by_subj to last_by_seq. The method now correctly passes sequence numbers under the right key.
lib/Nats/JetStream.rakumod:30-38 — to-map skips False booleans so allow-direct=False (default) is omitted from the stream config payload — matches NATS server convention.
lib/Nats/JetStream.rakumod:79 — allow-direct attribute added to Nats::Stream, defaulting to False.
t/direct-get-last.rakutest — New test file with 3 tests: body-only subject format, allow-direct=True included in config, allow-direct=False omitted. Now includes use lib 'lib'; per repo convention.
t/jetstream.rakutest — Updated get-msg test to expect last_by_seq (not last_by_subj). Added 2 tests for allow-direct create/config behavior.

🔄 Copilot Comments Addressed

Comment	Issue	Resolution
#3408858810	`get-msg` dead `:$subject` param	Fixed in `5ee7ed0` — removed parameter, simplified to `DIRECT-GET` only
#3408858816	`t/direct-get-last.rakutest` missing `use lib 'lib'`	Fixed in `535124b` — added `use lib 'lib';` (pushed to `hermes-fco/nats.raku:fix/direct-get-last`)

📊 Stats

Metric	Value
Files changed	3
Lines added	+95
Lines removed	−10
New tests	1 test file (`t/direct-get-last.rakutest`, 3 tests)
Security scan	Clean (no secrets, debug, merge conflicts)
New since last review	2 commits (`5ee7ed0`, `535124b`)

Reviewed by Hermes Agent

FCO requested a review from Copilot June 14, 2026 01:25

Copilot started reviewing on behalf of FCO June 14, 2026 01:25 View session

Copilot AI reviewed Jun 14, 2026

View reviewed changes

FCO merged commit 2ee7c7d into FCO:main Jun 14, 2026
1 check passed

Navigation Menu

fix: DIRECT-GET-LAST body-only format + allow-direct attribute - #6

fix: DIRECT-GET-LAST body-only format + allow-direct attribute#6
FCO merged 2 commits into
FCO:mainfrom
hermes-fco:fix/direct-get-last-subject

hermes-fco commented Jun 14, 2026

Uh oh!

hermes-fco commented Jun 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

hermes-fco Jun 14, 2026

Uh oh!

hermes-fco Jun 14, 2026

Uh oh!

Uh oh!

hermes-fco commented Jun 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hermes-fco commented Jun 14, 2026

Problem

Fix

TDD: RED → GREEN

Uh oh!

hermes-fco commented Jun 14, 2026

Code Review — fix: DIRECT-GET-LAST body-only format + allow-direct attribute

✅ Looks Good

⚠️ Warnings

💡 Suggestions

📊 Stats

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

hermes-fco Jun 14, 2026

Choose a reason for hiding this comment

Uh oh!

hermes-fco Jun 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hermes-fco commented Jun 14, 2026

Code Review — fix: DIRECT-GET-LAST body-only format + allow-direct attribute (re-review)

✅ Looks Good

🔄 Copilot Comments Addressed

📊 Stats

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Code Review — `fix: DIRECT-GET-LAST body-only format + allow-direct attribute`

Code Review — `fix: DIRECT-GET-LAST body-only format + allow-direct attribute` (re-review)