Update Reader according to the App Def modification.#22
Merged
Conversation
RubelMozumder
commented
Mar 24, 2025
Comment on lines
24
to
26
| # "pynxtools>=0.10.0", | ||
| "pynxtools @ git+https:github.com/FAIRmat-NFDI/pynxtools.git@update_SPM#egg=pynxtools", | ||
| # "pySPM==0.6.2", # SPM file reader for Bruker files use it when you have Bruker files |
Collaborator
Author
There was a problem hiding this comment.
Fix pynxtools version.
lukaspie
reviewed
Mar 25, 2025
| name: DemoName | ||
| sample_component_set: | ||
| sample_component: | ||
| Sample_component_set: |
Collaborator
There was a problem hiding this comment.
We had decided before to not use NXsample_component_set anymore (see nexusformat/definitions#1413). I suggest you keep it for now and refactor later.
Collaborator
There was a problem hiding this comment.
Note also that NXsample_component_set is not used in NXsample anymore. We should just drop this class at some point.
lukaspie
reviewed
Mar 25, 2025
| "findiff", | ||
| "pynxtools>=0.9.2", | ||
| # "pynxtools>=0.10.0", | ||
| "pynxtools @ git+https://github.com/FAIRmat-NFDI/pynxtools.git@update_SPM#egg=pynxtools", |
Collaborator
There was a problem hiding this comment.
remember to reset to pynxtools>=0.10.1
lukaspie
reviewed
Mar 25, 2025
Collaborator
lukaspie
left a comment
lukaspie
left a comment
There was a problem hiding this comment.
Why is there a zip file in the STSExampleWithCustomization?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the reacder accoding the modification that comes through the PR:
The changes are aligned with PR in pynxtools
3. FAIRmat-NFDI/pynxtools#578
What's to be modified:
pynxtool-spmpackage.