Skip to content

follow renaming of NXlens_em to NXelectromagnetic_lens#55

Merged
lukaspie merged 2 commits into
mainfrom
update-to-nxelectromagneticlens
Jul 29, 2025
Merged

follow renaming of NXlens_em to NXelectromagnetic_lens#55
lukaspie merged 2 commits into
mainfrom
update-to-nxelectromagneticlens

Conversation

@lukaspie
Copy link
Copy Markdown
Contributor

In nexusformat/definitions#1423 it was suggested by NIAC to rename NXlens_em to NXelectromagnetic_lens, in accordance with similar names like NXoptical_lens, NXoptical_window, etc.

We need to update the config and test .nxs files to reflect this. Works together with FAIRmat-NFDI/pynxtools#674.

@rettigl do we need to change that elsewhere as well?

@lukaspie lukaspie requested a review from rettigl July 28, 2025 13:26
@lukaspie lukaspie force-pushed the update-to-nxelectromagneticlens branch from b70839e to c960969 Compare July 28, 2025 13:39
@lukaspie
Copy link
Copy Markdown
Contributor Author

I had temporarily installed the bring_back_nexus_def branch in pytest.yaml and it worked: https://github.com/FAIRmat-NFDI/pynxtools-mpes/actions/runs/16570512453?pr=55

So we should be good to merge here and then rerun the plugin tests in pynxtools

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 16570512453

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.366%

Totals Coverage Status
Change from base Build 15823612244: 0.0%
Covered Lines: 131
Relevant Lines: 161

💛 - Coveralls

@lukaspie
Copy link
Copy Markdown
Contributor Author

@rettigl I will merge here so that we can continue working on the pynxtools main. Let me know if there are downstreams tools where a PR is needed to make the same change as here.

@lukaspie lukaspie merged commit 1b2c354 into main Jul 29, 2025
1 of 6 checks passed
@lukaspie lukaspie deleted the update-to-nxelectromagneticlens branch July 29, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants