follow renaming of NXlens_em to NXelectromagnetic_lens#55
Merged
Conversation
b70839e to
c960969
Compare
Contributor
Author
|
I had temporarily installed the So we should be good to merge here and then rerun the plugin tests in pynxtools |
Pull Request Test Coverage Report for Build 16570512453Details
💛 - Coveralls |
Contributor
Author
|
@rettigl I will merge here so that we can continue working on the pynxtools main. Let me know if there are downstreams tools where a PR is needed to make the same change as here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In nexusformat/definitions#1423 it was suggested by NIAC to rename
NXlens_emtoNXelectromagnetic_lens, in accordance with similar names likeNXoptical_lens,NXoptical_window, etc.We need to update the config and test .nxs files to reflect this. Works together with FAIRmat-NFDI/pynxtools#674.
@rettigl do we need to change that elsewhere as well?