Fixes in NXmpes

[lukaspie]

@rettigl I am not sure how one would write this now, both on the appdef level and in the file. Do you have a good suggestion? Even with this approach here, it is failing when I write ['kinetic_energy'] into the file

[rettigl]

I think exactly like that, it's the same here:

nexus_definitions/contributed_definitions/NXmpes_arpes.nxdl.xml

Line 342 in 1790395

<item value="['angular0', 'angular1', 'energy']"/>

I believe that worked at some point. I will have a look.

[rettigl]

This works for me:
"/ENTRY/CALIBRATION[transmission_correction]":{
"calibrated_axis": "@DaTa:angular0.data",
"transmission_function/@signal": "relative_intensity",
"transmission_function/@axes": "kinetic_energy",
"transmission_function/kinetic_energy": "@DaTa:angular0.data",
"transmission_function/kinetic_energy/@Units": "eV",
"transmission_function/relative_intensity": "@DaTa:angular0.data"
},
Changing @axes gives:
WARNING: The value at /ENTRY[entry]/CALIBRATION[transmission_correction]/transmission_function/@axes should be one of the following: ['kinetic_energy'].

[lukaspie]

But that is exactly the issue, @axes is supposed to be an array, see the screenshot.

In your implementation, @axes is just the single string "kinetic_energy", whereas it should be ["kinetic_energy"].

How do we need to denote the enum of an array of strings in the application definition and how should we write it in the template?

[rettigl]

You are right, I will check again.

[rettigl]

This works for me:

  "/ENTRY/CALIBRATION[transmission_correction]":{
    "calibrated_axis": "@data:angular0.data",
    "transmission_function/@signal": "relative_intensity",
    "transmission_function/@axes": ["kinetic_energy"],
    "transmission_function/kinetic_energy": "@data:angular0.data",
    "transmission_function/kinetic_energy/@units": "eV",
    "transmission_function/relative_intensity": "@data:angular0.data"
  },

The axes is indeed supposed to be a list of strings inside the file, not a single string.