Skip to content

Adjustments and bug fixes for cybran and seraphim factories#7130

Open
Saver27 wants to merge 3 commits into
FAForever:developfrom
Saver27:Adjustments-and-Bug-Fixes-for-Cybran-and-Seraphim-Factories
Open

Adjustments and bug fixes for cybran and seraphim factories#7130
Saver27 wants to merge 3 commits into
FAForever:developfrom
Saver27:Adjustments-and-Bug-Fixes-for-Cybran-and-Seraphim-Factories

Conversation

@Saver27
Copy link
Copy Markdown
Contributor

@Saver27 Saver27 commented May 25, 2026

Based on the review and feedback from user nory, I initially implemented three adjustments:

  1. Fixed an issue in the LOD1 model of the Seraphim T2 Land Factory, as it did not match the LOD0 model.
35 36
  1. Added an additional indicator to the Cybran T2 Naval Factory. This adjustment also required further changes to the animations of the T1 to T3 HQ factories.
33 34
  1. Fixed minor issues in the build animations of the Cybran Land Factories from T1 to T3, which caused unintended movement of the construction arms.

Summary by CodeRabbit

Visual Updates

  • Updated tread mark visuals for three units with improved textures and positioning
  • Enhanced left and right tread mark placement for more realistic movement trails
  • Adjusted tread mark spacing and size parameters for better visual presentation during unit movement

Review Change Stack

Saver27 added 2 commits May 15, 2026 19:30
- Replaced faulty `tank_treads06_albedo`
- Switched affected units to `tank_treads03_albedo`
- Fixed intermittent broken tread textures on:
  - Fatboy
  - Viper
  - Trebuchet
1. Fixed an issue in the LOD1 model of the Seraphim T2 Land Factory, as it did not match the LOD0 model.

2. Added an additional indicator to the Cybran T2 Naval Factory. This adjustment also required further changes to the animations of the T1 to T3 HQ factories.

3. Fixed minor issues in the build animations of the Cybran Land Factories from T1 to T3, which caused unintended movement of the construction arms.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 25, 2026

📝 Walkthrough

Walkthrough

Three unit blueprints receive consistent updates to their land movement tread mark visuals. The changes migrate from tank_treads06_albedo to tank_treads03_albedo and restructure tread placement using dual symmetric entries with mirrored X-axis offsets, adjusting interval, size, and positioning parameters per unit.

Changes

Tread Mark Configuration Updates

Layer / File(s) Summary
Unit tread mark material and placement updates
units/UEL0401/UEL0401_unit.bp, units/URL0111/URL0111_unit.bp, units/URL0304/URL0304_unit.bp
UEL0401 updates existing tread marks with new material and adjusted parameters. URL0111 and URL0304 replace single tread mark blocks with dual entries using mirrored X offsets for left/right placement, all three switching to tank_treads03_albedo with recalibrated sizes and intervals.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

type: bug, area: graphics, area: unit-blueprint

Suggested reviewers

  • lL1l1
  • Rhaelya
  • BlackYps

Poem

🐰 Through treads that mark the earthly ground,
Three units now in sync are found,
New textures blend with left and right,
Symmetric tracks in perfect sight!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions Cybran and Seraphim factories, but the changes shown are only tread texture updates for three tank units (no factory changes). Update the title to accurately reflect the actual changes, such as 'Fix tread textures for Fatboy, Viper, and Trebuchet units' or clarify what factory-related changes are included.
Description check ❓ Inconclusive PR description includes visual context but lacks structured documentation per template requirements. Missing changelog entry and explicit reviewer requests. Add a changelog snippet per repository guidelines and request 2-3 specific reviewers from the CONTRIBUTING.md list. Clarify which files contain each of the three mentioned changes.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ScrollTreads = true,
TreadMarks = {
{
TreadMarks = "tank_treads06_albedo",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to address my feedback - looks good so far. I believe the tread mark changes belong to another PR and slipped through by accident. Also, you pinged another Nory, this is my GH account 😄

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were right about the commit for the tread mark fix. It already has its own pull request. I’m not sure how it ended up here. Unfortunately, I’m still not very experienced with Git. The name "Nory" came from the forum post. I didn’t realize that you were active on Git as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants