Adjustments and bug fixes for cybran and seraphim factories#7130
Adjustments and bug fixes for cybran and seraphim factories#7130Saver27 wants to merge 3 commits into
Conversation
- Replaced faulty `tank_treads06_albedo` - Switched affected units to `tank_treads03_albedo` - Fixed intermittent broken tread textures on: - Fatboy - Viper - Trebuchet
1. Fixed an issue in the LOD1 model of the Seraphim T2 Land Factory, as it did not match the LOD0 model. 2. Added an additional indicator to the Cybran T2 Naval Factory. This adjustment also required further changes to the animations of the T1 to T3 HQ factories. 3. Fixed minor issues in the build animations of the Cybran Land Factories from T1 to T3, which caused unintended movement of the construction arms.
📝 WalkthroughWalkthroughThree unit blueprints receive consistent updates to their land movement tread mark visuals. The changes migrate from ChangesTread Mark Configuration Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| ScrollTreads = true, | ||
| TreadMarks = { | ||
| { | ||
| TreadMarks = "tank_treads06_albedo", |
There was a problem hiding this comment.
Thanks for taking the time to address my feedback - looks good so far. I believe the tread mark changes belong to another PR and slipped through by accident. Also, you pinged another Nory, this is my GH account 😄
There was a problem hiding this comment.
You were right about the commit for the tread mark fix. It already has its own pull request. I’m not sure how it ended up here. Unfortunately, I’m still not very experienced with Git. The name "Nory" came from the forum post. I didn’t realize that you were active on Git as well.
This reverts commit 327e0c8.
Based on the review and feedback from user nory, I initially implemented three adjustments:
Summary by CodeRabbit
Visual Updates