Skip to content

randomise default air unit elevation #7096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cx-koraka wants to merge 8 commits into
base: develop
Choose a base branch
from
+41 −0
Open

randomise default air unit elevation #7096

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
29f2fef
Add randomisation to the air unit elevation when created
cx-koraka Apr 16, 2026
1fd0a28
Fix param typo
cx-koraka Apr 16, 2026
74a30d2
Add snippet
cx-koraka Apr 16, 2026
be2bc8e
Access elevation safely, use sync-safe Random() function
cx-koraka Apr 16, 2026
9a73b25
remove errant +'s
cx-koraka Apr 16, 2026
2844ab9
add new category NORANDOMELEVATION, units with this category will not…
cx-koraka Apr 17, 2026
4bd6490
fix typos, optimise guards
cx-koraka Apr 17, 2026
0c18c0f
fix crash, extract vals to class level to make them hookable, change …
cx-koraka Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions lua/sim/units/AirUnit.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ AirUnit = ClassUnit(MobileUnit) {
MobileUnitOnCreate(self)
self.HasFuel = true
self:AddPingPong()
self:RandomiseElevation()
end,

---@param self AirUnit
Expand All @@ -40,6 +41,27 @@ AirUnit = ClassUnit(MobileUnit) {
end
end,

--@param self AirUnit
Copy link
Copy Markdown
Member

@speed2CZ speed2CZ Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to start with 3 --- to be a valid annotation

RandomiseElevation = function(self)
Copy link
Copy Markdown
Member

@speed2CZ speed2CZ Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be Randomize with z. The code is originally and mostly written in american english

local maxElevationDelta = 5
Comment thread
cx-koraka marked this conversation as resolved.
Outdated
local maxElevationPercentageIncrease = 5
local maxElevationPercentageDecrease = 5
Copy link
Copy Markdown
Member

@speed2CZ speed2CZ Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 2 different values for increase and decrease when they are the same?
Its not like a mod could easily adjust this, since its hardcoded in this function

Copy link
Copy Markdown
Author

@cx-koraka cx-koraka Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I moved these outside of the function, similar to the existing destruction params, would they be able to be changed by mods?
The original version of this had 30 and 0 as the max percentage increase and decrease respectively, this is a holdover

Copy link
Copy Markdown
Member

@speed2CZ speed2CZ Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if they are saved on the class, mods can easily adjust them without touching the function

Copy link
Copy Markdown
Author

@cx-koraka cx-koraka Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Hopefully this will make it easier to experiment whilst testing as well


local blueprintPhysics = self.Blueprint.Physics
local originalElevation = blueprintPhysics.Elevation
local elevationMultiplier = math.random(100-maxElevationPercentageDecrease, 100+maxElevationPercentageIncrease) * 0.01
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

local newElevation

if elevationMultiplier > 1 then
newElevation = math.min(originalElevation * elevationMultiplier, originalElevation + 5)
else
newElevation = math.max(originalElevation * elevationMultiplier, originalElevation - 5)
end

self:SetElevation(newElevation)
end,

---@param self AirUnit
---@param new VerticalMovementState
---@param old VerticalMovementState
Expand Down