-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[HOLD] Enable 16KB memory page size on Android #69161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 37 commits
1b582fe
c8e519f
e1871d0
b579616
1ae4dd5
29dad86
db87ce8
3a08162
c8b6ae4
db6da9a
47795fd
939cc7d
0ac7a67
4246383
808ae15
93ea3b3
a8f82c2
c30adc7
69d7408
4a813f4
c3163f2
5362897
0b27a61
0dabdb2
79548ce
8dd9b65
38bcd3d
e126fce
9a5d8a8
df54ee8
0ba1e85
bc1e090
2081da0
9730a54
148eeaa
2c6701e
5fbc4d5
081bff3
bb81143
23e2322
d2457ee
fa8c9f3
05e087c
12041a5
347c26f
8ee429e
cdd13d9
eee574b
0828ab2
06ac2e4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -100,7 +100,7 @@ | |
| "@fullstory/react-native": "^1.7.6", | ||
| "@gorhom/portal": "^1.0.14", | ||
| "@invertase/react-native-apple-authentication": "^2.2.2", | ||
| "@onfido/react-native-sdk": "10.6.0", | ||
| "@onfido/react-native-sdk": "^15.0.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not keen to upgrade so many unrelated dependencies all at once in a single PR. We should split this PR up in to several distinct PRs. In no particular order:
Then we can test, merge, deploy and QA them independently. This may take longer but will result in higher quality testing and lower likelihood of having to revert. If we do have to revert one of the dependency bumps, it doesn't affect the others.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure thing, we can use this PR as a ref and split it up into more atomic changes. Good call!
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| "@pusher/pusher-websocket-react-native": "^1.3.1", | ||
| "@react-native-camera-roll/camera-roll": "7.4.0", | ||
| "@react-native-clipboard/clipboard": "^1.15.0", | ||
|
|
@@ -118,7 +118,7 @@ | |
| "@react-navigation/native-stack": "7.3.14", | ||
| "@react-navigation/stack": "7.3.3", | ||
| "@react-ng/bounds-observer": "^0.2.1", | ||
| "@rnmapbox/maps": "10.1.33", | ||
| "@rnmapbox/maps": "^10.1.41-rc.2", | ||
| "@shopify/flash-list": "1.8.2", | ||
| "@ua/react-native-airship": "~24.4.0", | ||
| "awesome-phonenumber": "^5.4.0", | ||
|
|
@@ -134,7 +134,7 @@ | |
| "expo-asset": "^11.1.2", | ||
| "expo-av": "^15.1.5", | ||
| "expo-font": "^13.0.4", | ||
| "expo-image": "^2.1.6", | ||
| "expo-image": "^2.4.0", | ||
| "expo-image-manipulator": "^13.1.5", | ||
| "fast-equals": "^5.2.2", | ||
| "focus-trap-react": "^11.0.3", | ||
|
|
@@ -146,7 +146,7 @@ | |
| "lodash-es": "4.17.21", | ||
| "lottie-react-native": "6.5.1", | ||
| "mapbox-gl": "^2.15.0", | ||
| "onfido-sdk-ui": "14.42.0", | ||
| "onfido-sdk-ui": "^14.53.0", | ||
| "pako": "^2.1.0", | ||
| "process": "^0.11.10", | ||
| "pusher-js": "8.3.0", | ||
|
|
@@ -181,7 +181,7 @@ | |
| "react-native-nitro-sqlite": "9.1.10", | ||
| "react-native-onyx": "2.0.132", | ||
| "react-native-pager-view": "6.5.3", | ||
| "react-native-pdf": "6.7.3", | ||
| "react-native-pdf": "^6.7.7", | ||
| "react-native-performance": "^5.1.4", | ||
| "react-native-permissions": "^5.4.0", | ||
| "react-native-picker-select": "git+https://github.com/Expensify/react-native-picker-select.git#07d60d78d4772d47afd7a744940fc6b6d1881806", | ||
|
|
@@ -198,7 +198,7 @@ | |
| "react-native-tab-view": "^4.1.0", | ||
| "react-native-url-polyfill": "^2.0.0", | ||
| "react-native-view-shot": "4.0.0", | ||
| "react-native-vision-camera": "^4.7.0", | ||
| "react-native-vision-camera": "^4.6.1", | ||
|
Kureev marked this conversation as resolved.
|
||
| "react-native-web": "0.20.0", | ||
| "react-native-webview": "13.13.1", | ||
| "react-plaid-link": "3.3.2", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| diff --git a/node_modules/@onfido/react-native-sdk/android/build.gradle b/node_modules/@onfido/react-native-sdk/android/build.gradle | ||
| index 895bfd7..257605f 100644 | ||
| --- a/node_modules/@onfido/react-native-sdk/android/build.gradle | ||
| +++ b/node_modules/@onfido/react-native-sdk/android/build.gradle | ||
| @@ -93,6 +93,12 @@ android { | ||
| versionName "1.0" | ||
| multiDexEnabled true | ||
| consumerProguardFiles 'proguard-rules.pro' | ||
| + | ||
| + externalNativeBuild { | ||
| + cmake { | ||
| + arguments "-DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON" | ||
| + } | ||
| + } | ||
| } | ||
| lintOptions { | ||
| abortOnError false |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # `@onfido/react-native-sdk` patches | ||
|
|
||
| ### [@onfido+react-native-sdk+10.6.0+002+android-enable-16kb-memory-page-size.patch](@onfido+react-native-sdk+10.6.0+002+android-enable-16kb-memory-page-size.patch) | ||
|
|
||
| - Reason: Updates the packaging of the library on Android to enable 16KB memory page sizes on Android. | ||
| - Upstream PR/issue: TODO | ||
| - E/App issue: [#63871](https://github.com/Expensify/App/issues/63871) | ||
| - PR Introducing Patch: [#64640](https://github.com/Expensify/App/pull/64640) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| diff --git a/node_modules/@react-native-firebase/crashlytics/android/build.gradle b/node_modules/@react-native-firebase/crashlytics/android/build.gradle | ||
| index 9b89ae7..3069e6c 100644 | ||
| --- a/node_modules/@react-native-firebase/crashlytics/android/build.gradle | ||
| +++ b/node_modules/@react-native-firebase/crashlytics/android/build.gradle | ||
| @@ -67,6 +67,12 @@ project.ext { | ||
| android { | ||
| defaultConfig { | ||
| multiDexEnabled true | ||
| + | ||
| + externalNativeBuild { | ||
| + cmake { | ||
| + arguments "-DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON" | ||
| + } | ||
| + } | ||
| } | ||
| lintOptions { | ||
| disable 'GradleCompatible' | ||
| @@ -87,7 +93,11 @@ dependencies { | ||
| api appProject | ||
| implementation platform("com.google.firebase:firebase-bom:${ReactNative.ext.getVersion("firebase", "bom")}") | ||
| implementation "com.google.firebase:firebase-crashlytics" | ||
| - implementation "com.google.firebase:firebase-crashlytics-ndk" | ||
| + implementation ("com.google.firebase:firebase-crashlytics-ndk") { | ||
| + version { | ||
| + strictly "[19.0.2,)" | ||
| + } | ||
| + } | ||
| } | ||
|
|
||
| ReactNative.shared.applyPackageVersion() |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,4 @@ | |
| - Reason: The patch adapts `@react-native-firebase/crashlytics`'s build process to work reliably in our custom environment. | ||
| - Upstream PR/issue: Since this is tightly coupled to our specific Gradle configuration, it's not appropriate for upstream inclusion. | ||
| - E/App issue: This patch will remain in place to maintain compatibility with our build setup. | ||
| - PR introducing patch: N/A | ||
| - PR introducing patch: N/A | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not seeing any diff here. What is GitHub seeing that I'm not?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No idea, maybe some spacing or something? Happy to revert |
||
Uh oh!
There was an error while loading. Please reload this page.