Skip to content

adds back highlighting on hover#22

Open
gunnnnii wants to merge 2 commits intomainfrom
fix/hover-highlights
Open

adds back highlighting on hover#22
gunnnnii wants to merge 2 commits intomainfrom
fix/hover-highlights

Conversation

@gunnnnii
Copy link
Copy Markdown

@gunnnnii gunnnnii commented Oct 5, 2023

No description provided.

@gunnnnii gunnnnii requested a review from arnofiva October 5, 2023 07:34
@arnofiva
Copy link
Copy Markdown
Member

arnofiva commented Oct 6, 2023

PR looks good @gunnnnii, thanks!

Looking at the video, there used to be a label in the d3 graph when hovering, showing the building year and height (also name in some cases?). Have you tried adding that again?

Screenshot 2023-10-06 at 10 15 04 AM

@arnofiva
Copy link
Copy Markdown
Member

arnofiva commented Oct 6, 2023

Nice, great to have this functionality back! I checked with the version ae6f403 (based on JS SDK 4.11) and the only thing is that the font of the tooltips is larger and no longer bold. I'm guessing this is from changes to the style sheets between SDK versions. Could you try to tweak that?

4.11 version:

Screenshot 2023-10-06 at 4 35 08 PM

Latest version:

Screenshot 2023-10-06 at 4 34 52 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants