Skip to content

refactor: NoticePage 성능 최적화 #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minsu0707 merged 2 commits into from
Jan 19, 2026
Merged

refactor: NoticePage 성능 최적화 #210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a4a13c
refactor: NoticePage 성능 최적화
minsu0707 Jan 19, 2026
de5904f
fix : noticePage
minsu0707 Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 18 additions & 31 deletions apps/entry-user/src/pages/NoticePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useEffect, useState } from 'react';
import { useMemo, useState } from 'react';
import styled from '@emotion/styled';
import { colors, Flex } from '@entry/design-token';
import { NoticePinIcon, TabSection } from '@entry/ui';
Expand All @@ -10,45 +10,33 @@ interface NoticeItem {
title: string;
createdAt: string;
isPinned: boolean;
type: 'GUIDE' | 'NOTICE'
type: 'GUIDE' | 'NOTICE';
}

const TAB_OPTIONS = [
{ key: 'NOTICE', label: '입학 공지사항' },
{ key: 'GUIDE', label: '예비 신입생 안내' },
];

const formatDate = (dateString: string) => dateString.split('T')[0];

export const NoticePage = () => {
const [activeTab, setActiveTab] = useState<'NOTICE' | 'GUIDE'>(
'NOTICE'
);
const [activeTab, setActiveTab] = useState<'NOTICE' | 'GUIDE'>('NOTICE');
const navigate = useNavigate();
const { data, isLoading } = useGetAllNotice(activeTab);

const handleNoticeClick = (id: number) => {
navigate(`/notice/${id}`);
};

const handleTabChange = (tab: string) => {
const handleNoticeClick = (id: number) => navigate(`/notice/${id}`);
const handleTabChange = (tab: string) =>
setActiveTab(tab as 'NOTICE' | 'GUIDE');
};

const {data, isLoading} = useGetAllNotice(activeTab);
const [noticeItems, setNoticeItems] = useState<NoticeItem[]>([]);

const formatDate = (dateString: string) => {
return dateString.split('T')[0];
};

useEffect(() => {
if (data && Array.isArray(data?.notices)) {
const formattedNotices = data.notices.map(notice => ({
...notice,
createdAt: formatDate(notice.createdAt)
}));
setNoticeItems(formattedNotices);
}
}, [data]);

const noticeItems = useMemo(() => {
return (
data?.notices?.map((notice: NoticeItem) => ({
...notice,
createdAt: formatDate(notice.createdAt),
})) ?? []
);
}, [data]);

return (
<PageContainer>
Expand Down Expand Up @@ -76,12 +64,11 @@ export const NoticePage = () => {
{isLoading ? (
<LoadingRow>로딩 중...</LoadingRow>
) : noticeItems.length > 0 ? (
noticeItems.map((item) => (
noticeItems.map((item: NoticeItem) => (
<TableRow
key={item.id}
onClick={() => handleNoticeClick(item.id)}
>
{/* <ColumnNum>{item.id}</ColumnNum> */}
<ColumnNum>공지</ColumnNum>
<ColumnTitle>
{item.isPinned && (
Expand Down Expand Up @@ -205,4 +192,4 @@ const NewIconWrapper = styled.span`
margin-right: 8px;
display: inline-flex;
align-items: center;
`;
`;