Prakhar/ivfplus benchmarking - #22
Open
prakharjalan-aidb wants to merge 4 commits into
Open
Conversation
…an having a seperate suite, added initial benchmarking logic for ivfplus with configs for openai-500k-cos and openai-5m-cos
The 5k/50k/toy configs and the offline subset generator existed only on prakhar/ci-cd, which nothing pins. edb_vectorplus CI checks this branch out, so the suite it runs lives here now instead of being duplicated there. openai-5k-cos's second benchmark key was labelled "70" while setting probes: 71; relabelled to match, since that key names the series. Skips ci-cd's laion-5m-test-ip metric change (cos -> ip): every other config in this tree spells it dot, and pgvector_suite.py maps both to <#>.
Collaborator
|
Hey @prakharjalan-aidb, thanks for the PR. I think you should create a wrapper for the new extension so we keep extension's code separated. The same way we have split pgvector/vectorchord |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.