Skip to content

meson: add configurable config/log dir - #238

Merged
EmixamPP merged 1 commit into
EmixamPP:masterfrom
fufexan:meson-options
Sep 1, 2025
Merged

EmixamPP merged 1 commit into
EmixamPP:masterfrom
fufexan:meson-options

Conversation

@fufexan

@fufexan fufexan commented Aug 23, 2025 •

Copy link
Copy Markdown
Contributor

Allows modifying the config/log directories, as well as whether to install them.

I've made these changes in order to support installing on NixOS without patching. Should not impact how the program currently works on other systems.

Relevant Nixpkgs PR NixOS/nixpkgs#216245.

@fufexan fufexan mentioned this pull request Aug 23, 2025
9 of 17 tasks

@EmixamPP EmixamPP left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay no problem ! Just two adjustements to do

Comment thread meson.build
Comment thread meson.build Outdated
Comment thread src/meson.build
@EmixamPP
EmixamPP self-requested a review September 1, 2025 18:41
@github-actions

github-actions Bot commented Sep 1, 2025

Copy link
Copy Markdown

➡️ Commit 0083f93

🛠️ Building result: ✅

📦 Artifacts: ✅

  1. Download the tarball
  2. unzip linux-enable-ir-emitter*.tar.gz.zip
  3. Execute the install instructions

During the execution the tool raises an exception?
Please send us the gdb backtrace: sudo gdb --ex run --args linux-enable-ir-emitter <your command args>, once the crash arrives, type bt to show the error trace (q to exit)

🧪 Unit tests results: ✅

🩺 clang-tidy results: ✅

🎨 clang-format results: ✅

📋 Logs: meson-logs.zip

@EmixamPP
EmixamPP merged commit 790c0a8 into EmixamPP:master Sep 1, 2025
2 checks passed
@EmixamPP

EmixamPP commented Sep 1, 2025

Copy link
Copy Markdown
Owner

Do you need a release?

@fufexan

fufexan commented Sep 1, 2025

Copy link
Copy Markdown
Contributor Author

One would be nice, thanks.

@EmixamPP

EmixamPP commented Sep 1, 2025

Copy link
Copy Markdown
Owner

I will do that tomorrow or on Wednesday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants