Repository navigation
meson: add configurable config/log dir - #238
Merged
Merged
Conversation
9 of 17 tasks
EmixamPP
requested changes
Aug 30, 2025
EmixamPP
left a comment
Owner
There was a problem hiding this comment.
Okay no problem ! Just two adjustements to do
fufexan
force-pushed
the
meson-options
branch
from
September 1, 2025 17:32
9d34d1e to
2496582
Compare
EmixamPP
reviewed
Sep 1, 2025
EmixamPP
self-requested a review
September 1, 2025 18:41
fufexan
force-pushed
the
meson-options
branch
from
September 1, 2025 19:31
2496582 to
9f2061e
Compare
fufexan
force-pushed
the
meson-options
branch
from
September 1, 2025 19:31
9f2061e to
0083f93
Compare
➡️ Commit 0083f93🛠️ Building result: ✅📦 Artifacts: ✅
During the execution the tool raises an exception? 🧪 Unit tests results: ✅🩺 clang-tidy results: ✅🎨 clang-format results: ✅📋 Logs: meson-logs.zip |
EmixamPP
approved these changes
Sep 1, 2025
Owner
|
Do you need a release? |
Contributor
Author
|
One would be nice, thanks. |
Owner
|
I will do that tomorrow or on Wednesday |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows modifying the config/log directories, as well as whether to install them.
I've made these changes in order to support installing on NixOS without patching. Should not impact how the program currently works on other systems.
Relevant Nixpkgs PR NixOS/nixpkgs#216245.