Skip to content

Fix RPC return errors for psbt and invalid rangeproofs - #1593

Merged
delta1 merged 7 commits into
ElementsProject:masterfrom
tomt1664:assort_fixes
Sep 1, 2026
Merged

Fix RPC return errors for psbt and invalid rangeproofs#1593
delta1 merged 7 commits into
ElementsProject:masterfrom
tomt1664:assort_fixes

Conversation

@tomt1664

@tomt1664 tomt1664 commented Sep 1, 2026

Copy link
Copy Markdown
Member

Fixes for a number of issues with RPC errors for invalid PSBTs and amounts/rangeproofs.

@tomt1664 tomt1664 changed the title Fix RPC return errors for psbt and invalid rangeproofs. Fix RPC return errors for psbt and invalid rangeproofs Sep 1, 2026

@delta1 delta1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just 1 comment

Comment thread src/wallet/wallet.cpp Outdated
Comment thread src/blind.cpp Outdated

@delta1 delta1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a9db3b1; tested locally

@delta1
delta1 merged commit 4ddaefc into ElementsProject:master Sep 1, 2026
6 of 7 checks passed
tomt1664 pushed a commit to tomt1664/elements that referenced this pull request Sep 2, 2026
…d rangeproofs

a9db3b1 Add startup warning for signed-blocks parent chain (Tom Trevethan)
246c5ab Add virtual desctructor to CChainParams (Tom Trevethan)
779e71f PAK enforcement on confidential nAsset (Tom Trevethan)
ffd91c0 PartiallySignedTransaction::SetupFromTx indexes vtxinwit checked (Tom Trevethan)
84a05e3 check pubkey validity in tweakfedpegscript to prevent assert failure (Tom Trevethan)
3a8dec1 Return error for psbt if explicit amounts/assets deleted (Tom Trevethan)
4e5ca94 Return error for invalid rangproof amounts (Tom Trevethan)

Pull request description:

  Fixes for a number of issues with RPC errors for invalid PSBTs and amounts/rangeproofs.

ACKs for top commit:
  delta1:
    ACK a9db3b1; tested locally

Tree-SHA512: bf35348a5fad30e0f1f2b3caa2ec35ec521b583155e97f3a5f2504a3d70b41677f215fc01b28ccd30706ff5a7d021afb74c110a2c8f270942f5cba344544a55d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants