chore(cpn): upgrade to Ubuntu 22.04 and Qt 6.9.0#5986
Conversation
|
No need for this one as nightlies don't run on PR context. ;) I'm heading out now so can't look at the build errors sorry. |
Undid that one |
|
I thought I got rid of the compiler warnings only to have a plethora of new ones come to light in win and mac :-( |
|
Compiles across all OSes and reduced compiler warnings to as few as possible. |
|
A quick "does it run" test of the Linux build suggests that it does (on Linux Mint 22)... loaded up fine, and was able to view, edit and simulate an ETX file. Simulator froze during radio setup when I set a valid SD card path, so possibly something around sound again, although simple "beep" sounds worked if I didn't have the path set. The AppImage is definitely putting on weight though... 🐘 ... here are the zip file packages for some of the recent releases... 😆 |
|
Not surprisingly appimage growing so is the devcontainer. |
|
Sounds are imbedded in the executable resources but from memory still get played the same. |
be3fb77 to
f9317a7
Compare
|
Since this is referencing 6.8.2 also (so same as EdgeTX/build-edgetx#24) can you rebase again or push some other commit to this so I can see if the commit tests still work (or not work), and if pillow needs to be pinned again. 🤪 No great rush. 😪 |
|
@pfeerick tested using Linux Companion workflow AppImage. Companion SF play button and tx16S sim on Ubuntu 22.04 and Mint Cinnamon 22.01 VMs and sound heard. |
8239da4 to
65edb6c
Compare
|
Going to try macdeployqt to fix mac packaging and hopefully reduce the customisation |
|
MacOS package built but does it work? I do not have one so can one of of you MacOS devs please test. |
|
Does not run on MacOS:
|
@philmoz appreciate you testing. I half expected the missing as I suspected it might use the inbuilt cpack DnD. Need to work out the combination of variables. Worse part is how long it takes to build to either fail or succeed and then have someone like yourself check the result. |
8d39257 to
4db90df
Compare
9801edd to
c39ae51
Compare
c39ae51 to
b05203d
Compare
7971ffa to
f485862
Compare
9d08d06 to
67938cc
Compare
This reverts commit 08d8ab3.
45b8171 to
bfad0bd
Compare
There was a problem hiding this comment.
This appears to be working perfectly on both Linux Mint and Windows 11 - was able to read/write from radio, ETX file, edit some stuff, preview settings for printing, do update checks, sync SD card, simulate, etc.
The annoying audio not working in model SF tab gremlin seems to be banished also!
Only spotted one minor issue, probably due to some resizing of UI widgets or something... checkboxes were clipped here on the right side on Windows. Oh, and the simulator buttons radio are being silly... not always turning red. Otherwise LGTM! Quite like the new look of the trim/switch sliders :)
|
One complications - once I install Qt 6 (via homebrew), I can't build main branch or older versions such as 2.11. |
|
Are you doing a clean build when switching back to main/2.11? i.e. so that no QT6 paths are being cached in cmake configuration files? They should be installing into different versioned folders by default... thus able to run multiple versions side by side. Double check environment variables also... ie. .CMAKE_PREFIX_PATH, Qt5_DIR, etc. And of course, the cmake in main/2.11 might be daft and find QT6 before QT5 or something... hm... shouldn't be from the looks of it though... it is specifically looking for QT5 libraries... 🤔 |
I was able to work around this by deleting all the /usr/local/include/Qt* softlinks that were installed by Qt6. |
8f12c89 to
df6d7e2
Compare
Another case of dynamic ui build not auto sizing like it should. Likely needs an explicit kick which I will look at.
A combination of events in libsim and Qt not executing in the expected sequence. It is more noticeable when the libsim is running its startup processes which can be quite long especially for colour radio. Once stabilised it is less frequent. Only a short term issue until the new sims are released. |
I'd suggest tackling this in a follow-up PR. We need to move on. So many things waiting for this huge PR to be merged. |
df6d7e2 to
c964013
Compare

Summary of changes:
TODO: (some may roll over into a post merge PR)
Notes:
Warning: reverts libsims to run inline in Companion due to the unsolvable termination crash in Windows when launching the standalone simulator. This re-introduces the libsim initialisation bug for those libsims which do not unload.